Add enableBinaryBeforeFix() #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow check to see if Unicore library needs lone control of serial hardware.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the receiver has not yet achieved GNSS fix, binary messages such as BESTNAVB and RECTIMEB do not return an OK when started, resulting in a long (1.5s) timeout each time the message is started or restarted. This PR leaves that behavior in place, but if disableBinaryBeforeFix() is called during the GNSS setup, then any calls to getLatitude() or getYear() will trigger a BESTNAVB start, but immediately exit before the command is sent to avoid timeout blocking. Once a successful GGA NMEA message reports a 3D fix is achieved, BESTNAV and RECTIME will be started.
If NMEA GGA is not enabled, avoid using disableBinaryBeforeFix.