Add RP2 DVI HSTX driver #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inherit from CV2_Display Properly implement imshow() and clear() Add gray8 and bgra8888 conversion functions to cv2_display.py Import from displays/__init__.py Move test code to new example
gigapod
approved these changes
Nov 20, 2025
Member
gigapod
left a comment
gigapod
left a comment
There was a problem hiding this comment.
No obvious issues that I see.
Well structure/commented code. Bonus points for ASCII diagrams!
malcolm-sparkfun
approved these changes
Nov 20, 2025
malcolm-sparkfun
left a comment
malcolm-sparkfun
left a comment
There was a problem hiding this comment.
I left a couple of minor nits that you can choose to disregard at your leisure.
This is a very impressive piece of code :)
In anticipation of micropython/micropython#18458, which is slated for the v1.27.0 release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.