fix: resolve webpack/Next.js WASM data URL compatibility issue (#95) #231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…jsdev#95) Add Vite plugin to remove unnecessary `import.meta.url` argument from data: URLs during build. ## Problem wasm-pack generates: `new URL("data:...", import.meta.url)` The `import.meta.url` argument is unnecessary for data: URLs and causes: - Webpack 5: "Invalid generator object" error - Vite: Incorrectly rewrites URL as filesystem path ## Solution Transform during build: - Before: `new URL("data:...", import.meta.url)` - After: `new URL("data:...")` This allows Next.js/webpack users to import spark normally without errors. Fixes sparkjsdev#95
Contributor
|
Thanks so much for this! |
Collaborator
|
This breaks the source-map. Should use magic-string to make the substitution and generate the right mapping. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Vite plugin to remove unnecessary
import.meta.urlargument from data: URLs during build.Problem
wasm-pack generates:
new URL("data:...", import.meta.url)The
import.meta.urlargument is unnecessary for data: URLs and causes:Solution
Transform during build:
new URL("data:...", import.meta.url)new URL("data:...")This allows Next.js/webpack users to import spark normally without errors.
Fixes #95