Support plain x/y/z/r/g/b point clouds in ply files#340
Merged
Conversation
Contributor
Contributor
|
Thanks @mrxz |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #329
This PR implements point cloud decoding support in the
spark-libproject. It only considers a .ply file a point cloud if it contains all of the following properties:x,y,z,red,green,blue. It also supports an optionalalphaproperty, similar to how Spark 0.1 handled it.Since point clouds don't have scale or rotation, a fixed scale of 0.001 is chosen for all three axis. This is the same default/fallback value as in Spark 0.1, but unlike the old approach, this value can't be configured as the constant is on the Rust side of the project.
It's likely that there are still differences in behaviour between this implementation and the old one, especially given that the old one mixed splat and point cloud handling (e.g. it was theoretically possible to have point clouds with spherical harmonics). Testing was done by loading a coloured point cloud file exported from CloudCompare