Handle the file argument properly#283
Merged
tenderlove merged 3 commits intosparklemotion:masterfrom Jul 4, 2020
yb66:patch-1
Merged
Handle the file argument properly#283tenderlove merged 3 commits intosparklemotion:masterfrom yb66:patch-1
tenderlove merged 3 commits intosparklemotion:masterfrom
yb66:patch-1
Conversation
The argument is a file *path* but is called *file* and yet it's treated as a string. If passed an actual File or a Pathname it will be properly handled.
Member
|
@yb66 do you mind adding a test for this? |
Contributor
|
Windows behaves a bit differently with file handles. The test below passes CI: def test_filename_to_path
tf = Tempfile.new 'thing'
pn = Pathname tf.path
db = SQLite3::Database.new pn
assert_equal pn.expand_path.to_s, File.expand_path(db.filename)
ensure
tf.close! if tf
end |
Contributor
Author
|
Thanks @MSP-Greg. Regards, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The argument is a file path but is called file and yet it's treated as a string.
If passed an actual File or a Pathname it will be properly handled.