test: assert compiled and loaded versions of sqlite3 are the same, update sqlite3-ruby.yml#336
Merged
flavorjones merged 3 commits intosparklemotion:masterfrom Aug 12, 2022
Conversation
flavorjones
force-pushed
the
00-pr-333-test-versions
branch
from
7c59b65 to
a8bb084
Compare
Member
|
Thank you for this! Merging. |
Contributor
Author
|
Mike, I was working a fix for the other workflow file, as I didn't notice failures in it before when looking at PR #333. I also had a message, but was doing both at the same time you merged this. I'll open another PR with a fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to PR #333, adds a test to verify that compile & runtime sqlite3 versions are the same.
From watching Puma & EventMachine (both compile with OpenSSL), macOS has issues when using brew packages, the solution here is to use
--with-opt-dir=$(brew --prefix sqlite3)when compiling.Third comment can be removed, it just contains reformatting of the Actions yaml...
Failure with TruffleRuby-head, see PR #334 for info. It is a recent failure.