Fix use-after-free issue with custom functions#710
Merged
Conversation
when the same function name is used with multiple arities. ref: GHSA-28hh-pr2h-2w89
There was a problem hiding this comment.
Pull request overview
This PR addresses a potential use-after-free when defining multiple SQLite custom functions with the same name but different arities by ensuring Ruby Proc objects remain referenced for the lifetime of the SQLite3::Database instance.
Changes:
- Retain all function blocks on the database instance (switch
@functionsfrom a name-keyed hash to an array) to prevent GC from freeing blocks still referenced by SQLite. - Add a regression test covering redefining a function name with a different arity and forcing GC.
- Update
create_functiondocumentation to clarify that function blocks are kept alive for the database lifetime.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
test/test_database.rb |
Adds regression test intended to reproduce the UAF scenario after GC. |
lib/sqlite3/database.rb |
Changes @functions storage type and documents lifetime retention of function blocks. |
ext/sqlite3/database.c |
Pushes function blocks into @functions array to keep them referenced and GC-safe. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| def test_redefine_function_with_different_arity_does_not_use_freed_block | ||
| @db.define_function("f") { |a| "orig" } | ||
| @db.define_function("f") { |a, b| "new" } | ||
| GC.start(full_mark: true, immediate_sweep: true) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when the same function name is used with multiple arities.
ref: https://github.com/sparklemotion/sqlite3-ruby/security/advisories/GHSA-28hh-pr2h-2w89