DM-001: Fix dimension mismatch — align all embeddings to 384#21
Merged
DM-001: Fix dimension mismatch — align all embeddings to 384#21
Conversation
Vector indexes were hardcoded to 768-dim but ONNX MiniLM-L6 produces 384-dim embeddings. HNSW index could never be built — all searches fell back to brute-force. Neural training was capped at 256-dim, preventing neural patterns from sharing the memory index. Fixes: - vector_indexes schema: 768 → 384 (matches MiniLM-L6 output) - reasoningbank/agentic-flow fallback dimensions: 768 → 384 - neural --dim max/default: 256 → 384 (same dimension as memory) Result: all embedding paths produce 384-dim vectors that match the HNSW index configuration. HNSW can now be built and used. Co-Authored-By: claude-flow <ruv@ruv.net>
sparkling
added a commit
that referenced
this pull request
Mar 14, 2026
) Supersedes PR #21 (which set 384-dim). The target machine has 32 cores + 187GB RAM — can easily run all-mpnet-base-v2 (110M params, ~5ms/embed). Changes: - ONNX model: all-MiniLM-L6-v2 (384-dim) → all-mpnet-base-v2 (768-dim) - Vector indexes: 384 → 768 (now matches model output) - Neural --dim: max/default 384 → 768 (shares same HNSW index) - All dimension fallbacks aligned to 768 - MCP tools: default model updated, MiniLM kept as enum option All embedding paths now produce 768-dim vectors matching the HNSW index. Co-Authored-By: claude-flow <ruv@ruv.net>
sparkling
added a commit
that referenced
this pull request
Mar 14, 2026
Patches applied: - HK-002: fail-loud bridge errors in postEdit/postCommand/postTask (#18) - HK-003: real metrics from sona-patterns/intelligence files (#19) - HK-004: respect daemon.autoStart from settings.json (#20) - HK-005: cross-process daemon PID-file guard (#21) - NS-001: search/list default namespace 'default' → 'all' (#22) - NS-002: require explicit namespace for store/delete/retrieve (#23) - NS-003: fix 'pattern' → 'patterns' namespace typo (#24) - WM-103: MetadataFilter + MMR diversity in search pipeline (#25) - WM-104: CausalRecall integration in routing (#26) - WM-105: MemoryGraph importance scoring in store/search (#27) - WM-106: activate LearningBridge in intelligence_learn (#28) - WM-107: fix falsy-OR quality bug, fake session ID/stats (#29) - WM-114: wire AttentionService across 4 controllers (ruvnet#30) Co-Authored-By: claude-flow <ruv@ruv.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #20. Vector indexes (768), ONNX (384), neural (256) all mismatched. Aligned everything to 384-dim.