Skip to content

Conversation

@WesCossick
Copy link
Member

When it detects a click outside of the menu, it will close it.

This also tightens the Puppeteer testing, which may solve #39.

@codecov
Copy link

codecov bot commented Dec 19, 2019

Codecov Report

Merging #51 into master will decrease coverage by 8.3%.
The diff coverage is 27.27%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #51      +/-   ##
==========================================
- Coverage   87.71%   79.41%   -8.31%     
==========================================
  Files           1        1              
  Lines          57       68      +11     
  Branches       17       20       +3     
==========================================
+ Hits           50       54       +4     
- Misses          7       14       +7
Impacted Files Coverage Δ
src/use-dropdown-menu.ts 79.41% <27.27%> (-8.31%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65a3145...1176a5a. Read the comment docs.

@WesCossick WesCossick marked this pull request as ready for review December 19, 2019 20:49
@WesCossick WesCossick merged commit cca088f into master Dec 19, 2019
@WesCossick WesCossick deleted the add-click-elsewhere-listener branch December 19, 2019 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants