Skip to content

Conversation

@larsoner
Copy link
Collaborator Author

Looks like the error is actually not in our command but actually later in CIBUILDWHEEL's. Let's see if removing 3.5 (which is EOL imminently anyway) helps

@larsoner larsoner changed the title MAINT: User install for Windows MAINT: Simplify CIBUILDWHEEL command to avoid pip install error Aug 20, 2020
@larsoner
Copy link
Collaborator Author

Okay this one should be good to go @mgeier . Let me know if you want me to remove 3.5 in this PR -- I'm +1 for doing so, it's EOL a few weeks from now. But otherwise this fixes the Azure failure by simplifying the YAML and explicitly sets python_requires>=3.5 in setup.py since that's all we test/build for, and 2.7 reached EOL months ago.

@mgeier
Copy link
Member

mgeier commented Aug 20, 2020

Thanks!

Let me know if you want me to remove 3.5 in this PR

We should remove it after the next release (which we can make immediately after this PR is done).
If we do it before, Python 2.x users will not be able to install the latest supported version (AFAIK).

@larsoner
Copy link
Collaborator Author

Okay, 3.5 bump reverted

@larsoner larsoner merged commit 2c650f3 into spatialaudio:master Aug 20, 2020
@larsoner
Copy link
Collaborator Author

@mgeier do you want to push out a release now, or want me to do it?

@larsoner larsoner deleted the pip branch August 20, 2020 18:19
@mgeier
Copy link
Member

mgeier commented Aug 20, 2020

If you want to do it, please go ahead!

@mgeier
Copy link
Member

mgeier commented Aug 23, 2020

Thanks @larsoner for the release!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants