Skip to content

[UNR-4795] Reset server movement data on local client possession. #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 13, 2021
Merged

[UNR-4795] Reset server movement data on local client possession. #242

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d08213b
Reset server movement data when AIController is setup on client
ImprobableNic Jan 12, 2021
2de9248
Comment
ImprobableNic Jan 12, 2021
9cbeb8e
Better comment
ImprobableNic Jan 12, 2021
6a7ec8d
Even Better comment
ImprobableNic Jan 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified Game/Content/Characters/BP_SimulatedPlayerCharacter.uasset
View file
Open in desktop
Binary file not shown.
5 changes: 5 additions & 0 deletions Game/Source/GDKShooter/Private/Characters/GDKCharacter.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,3 +209,8 @@ bool AGDKCharacter::CanBeSeenFrom(const FVector& ObserverLocation, FVector& OutS
OutSightStrength = (float)PositiveHits / (float)NumberOfLoSChecksPerformed;
return PositiveHits > 0;
}

void AGDKCharacter::ClientMovementReset_Implementation()
{
GetCharacterMovement()->ResetPredictionData_Server();
}
7 changes: 7 additions & 0 deletions Game/Source/GDKShooter/Public/Characters/GDKCharacter.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,13 @@ class GDKSHOOTER_API AGDKCharacter : public ACharacter, public IGenericTeamAgent
UFUNCTION(BlueprintNativeEvent, BlueprintCallable)
void StartRagdoll();

// ----- HACKY WORKAROUND, KEEP AWAY FROM PRODUCTION CODE ----
// This class is used by simplayer, which locally replaces the Pawn's controller without the server's knowledge
// Unpossessing a character resets its movement data, so this is used to inform the server that it happened.
// Getting rid of this hack means adding AIController-like capabilities to the regular PlayerController.
UFUNCTION(BlueprintCallable, Server, Unreliable)
void ClientMovementReset();

private:
UFUNCTION()
void DeleteSelf();
Expand Down