[UNR-4795] Reset server movement data on local client possession. #242
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Corresponding JIRA ticket: https://improbableio.atlassian.net/browse/UNR-4795 |
improbable-prow-robot
added
jira/UNR
size/XS
ImprobableNic
requested review from
MatthewSandfordImprobable and
improbable-valy
Contributor
|
You may be able to remove the component enables and disabled now I think. |
Contributor
Author
|
@MatthewSandfordImprobable Unfortunately no, this is used to purge the buffer of outgoing moves. |
improbable-valy
approved these changes
Jan 12, 2021
MatthewSandfordImprobable
approved these changes
Jan 13, 2021
improbable-prow-robot
deleted the
bugfix/UNR-4795-reset-server-movement-data
branch
MatthewSandfordImprobable
pushed a commit
that referenced
this pull request
Feb 3, 2021
* Release candidate for version 0.12.0. * Upgrade preview 7 (#241) * Update to preview 7 * update nightly steps * Revert * Formatting revert * Add new line * [UNR-4795] Reset server movement data on local client possession. (#242) * Update to preview 8 (#243) * Prevent values being left in PatrolPoint::OccupiedBy (#246) * Upgrade to 15.0.0 (#247) * Upgrade to 15.0.0 * Upgrade DeployGame * Prepare GDK for Unreal release 0.12.0. * Update version file Co-authored-by: MatthewSandfordImprobable <matthewsandford@improbable.io> Co-authored-by: Nicolas Colombe <nicolascolombe@improbable.io> Co-authored-by: Danny Birch <danielbirch@improbable.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SimPlayer are doing the hacky thing of replacing their PlayerController with an AIController. When that happens, the client's movement data is reset(timestamp goes back to 0), but the server data is still there, not knowing that anything happened client side. So to get them back in sync, I added a server RPC to reset the movement data on the server.
Changes to BP_SimulatedPlayerCharacter, with comments.