Prevent values being left in PatrolPoint::OccupiedBy #246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Corresponding JIRA ticket: https://improbableio.atlassian.net/browse/UNR-4770 |
improbable-prow-robot
added
jira/UNR
size/XS
MatthewSandfordImprobable
approved these changes
Jan 18, 2021
mironec
approved these changes
Jan 18, 2021
Contributor
Author
This isn't success and returns back to the first step
If that were to happen it would - although it shouldn't happen now that the OccupiedBy is cleared correctly when assigning a new patrol location. Patrol points are is an array of objects which the spawner shuffles and looks for unoccupied ones, so the bug that existed was not clearing this meant that patrol points could not be found eventually |
MatthewSandfordImprobable
pushed a commit
that referenced
this pull request
Feb 3, 2021
* Release candidate for version 0.12.0. * Upgrade preview 7 (#241) * Update to preview 7 * update nightly steps * Revert * Formatting revert * Add new line * [UNR-4795] Reset server movement data on local client possession. (#242) * Update to preview 8 (#243) * Prevent values being left in PatrolPoint::OccupiedBy (#246) * Upgrade to 15.0.0 (#247) * Upgrade to 15.0.0 * Upgrade DeployGame * Prepare GDK for Unreal release 0.12.0. * Update version file Co-authored-by: MatthewSandfordImprobable <matthewsandford@improbable.io> Co-authored-by: Nicolas Colombe <nicolascolombe@improbable.io> Co-authored-by: Danny Birch <danielbirch@improbable.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Game/Content/Blueprints/NPCs/BTTask_UnocupyPatrolPoint.uasset
Modifying this to deal with the case that the object isn't set, which is valid
Before
After
Game/Content/Blueprints/NPCs/BT_NPC.uasset
Moving Unocupy before finding a new point, this ensures that if it was already assigned to a patrol point it will unassign before finding a new one.
Before
After