Skip to content

Conversation

oblm
Copy link
Contributor

@oblm oblm commented Aug 15, 2019

Description

Merges the 0.6.1-hotfix changes back into master

Tests

@oblm & @m-samiec performed the release testing process.
@oblm re-tested every fix listed in the CHANGELOG.

improbable-valy and others added 8 commits June 25, 2019 15:51
* Clarify elements of the GDK

* Remove duplicate and outdated info

* Changes from review
Offloading workers AIWorker / CrashWorker should not start by default in example project. Disabling offloading should have this effect.
In AGDKCharacter::BeginPlay a callback is registered on the UEquippedComponent::HoldableUpdated. This callback is used to attach the new AHoldable to the player's skeleton.

Blueprint subclasses: BP_Base_Character, and BP_FPS_Character had overridden BeginPlay but not called the Parent function, so the callback was not attached.

This meant that if a weapon was checked out after the character, it would not be attached, and would stay floating where it was spawned.
@oblm oblm requested a review from improbable-valy August 15, 2019 14:31
@improbable-prow-robot improbable-prow-robot added the jira/no-ticket Indicates a PR has no corresponding JIRA ticket label Aug 15, 2019
@oblm oblm added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 15, 2019
@improbable-prow-robot improbable-prow-robot added size/M Denotes a PR that changes 40-149 lines, ignoring generated files. labels Aug 15, 2019
@oblm oblm removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 15, 2019
@improbable-valy improbable-valy merged commit 5100f3d into master Aug 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/no-ticket Indicates a PR has no corresponding JIRA ticket size/M Denotes a PR that changes 40-149 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants