Skip to content
This repository was archived by the owner on Jan 18, 2022. It is now read-only.

Conversation

@jamiebrynes7
Copy link
Contributor

@jamiebrynes7 jamiebrynes7 commented Nov 14, 2018

Description

The saga continues (from #611)! This PR comes with:

  • A new snapshot!
  • Improved commit ordering
  • RequestIds as longs instead of uints
  • Lots of CInteropy-ness

Tests

The standard stuff really.

Documentation

Changelog.

@jamiebrynes7 jamiebrynes7 requested review from a user, dgavedissian and samiwh November 14, 2018 14:57
@improbable-prow-robot improbable-prow-robot added the size/XXL Denotes a PR that changes 600+ lines, ignoring generated files. label Nov 14, 2018
Jamie Brynes added 7 commits November 15, 2018 12:30
update sdk version again
adjust comments

add implicit casts

remove implicit casts
fix codegen

codegen request id stuff

fix codegenerator
regenerate test gen code

update gen code again

generated code

generated code again;
changelog
@jamiebrynes7 jamiebrynes7 merged commit 37639bb into master Nov 15, 2018
@jamiebrynes7 jamiebrynes7 deleted the feature/13.4-snapshot branch November 15, 2018 15:32
jessicafalk pushed a commit that referenced this pull request Nov 15, 2019
… update (#618)

* UNR-696 Shadow data for replicated properties isn't updated if you receive an update

- refresh the shadow data on authoritygained()
- changed which static buffer we use for InitShadowData and ApplySchemaObject

* reverting shadow buffer usage switch from previous commit

* reverting componentreader.cpp

* white space

* Update SpatialActorChannel.cpp

* removing unneccessary diff

* incorporating feedback from review

* Update SpatialGDK/Source/SpatialGDK/Public/Interop/SpatialReceiver.h

Co-Authored-By: chrisfields0 <christopherfields@improbable.io>

* Update SpatialGDK/Source/SpatialGDK/Private/EngineClasses/SpatialActorChannel.cpp

Co-Authored-By: chrisfields0 <christopherfields@improbable.io>

* Update SpatialGDK/Source/SpatialGDK/Private/Interop/SpatialReceiver.cpp

Co-Authored-By: chrisfields0 <christopherfields@improbable.io>

* Update SpatialGDK/Source/SpatialGDK/Private/EngineClasses/SpatialActorChannel.cpp

Co-Authored-By: chrisfields0 <christopherfields@improbable.io>

* compile error
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

size/XXL Denotes a PR that changes 600+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants