This repository was archived by the owner on Jan 18, 2022. It is now read-only.
Build System Tweaks #706
Merged
Build System Tweaks #706
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 24, 2019 13:27
jamiebrynes7
added
T: enhancement
improbable-prow-robot
added
the
size/M
zeroZshadow
approved these changes
Jan 24, 2019
gkassabli
approved these changes
Jan 24, 2019
| - Updated the `MobileWorkerConnector` to use the KCP network protocol by default. | ||
| - Changed the `mobile_launch.json` config to use the new Runtime. | ||
| - Updated all the launch configs to use the new Runtime. | ||
| - Changed the way builds are processed in the Unity Editor. If you don't have build support for a particular target, that specific build target will be skipped rather than the whole build process cancelled. |
There was a problem hiding this comment.
Can we drop the first sentence and just say something like "Changed the Unity Editor building process to skip builds with missing targets"?
There was a problem hiding this comment.
I might be cheeky and change it in #705 so I don't have to rerun CI here 😛
There was a problem hiding this comment.
Unless people have code concerns
jessicafalk
approved these changes
Jan 24, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A last minute addition to the
0.1.4releasegrumble grumble- adjusting the build system to skip builds that you don't have build support for (without cancelling the other builds).For example - if you build all workers without mobile support installed you would get the following messages in the console.
Also the static
Buildmethod still throws if build support is missing (such that the process actually returns an error exit code) - so that behavior is unchanged.Tests
Tested a build locally and via command line.
Documentation
How is this documented (for example: release note, upgrade guide, feature page, in-code documentation)?
Did you remember a changelog entry?
Yes
Primary reviewers
If your change will take a long time to review, you can name at most two primary reviewers who are ultimately responsible for reviewing this request. @ mention them.
@jessicafalk @jared-improbable