[COMP-673] Add description and runtime version #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benclive
reviewed
Mar 11, 2019
| commit = "246c6a1db4e352b51f4d2197cdf600077ab41bce", | ||
| shallow_since = "2018-12-01", | ||
| commit = "777672f36dbc103621ee04dec1786da2cdd48599", | ||
| shallow_since = "2019-02-01", |
There was a problem hiding this comment.
I'm not entirely sure what this date is, but it should probably be the date of the commit (13th Feb)?
Contributor
Author
There was a problem hiding this comment.
I thought so too, but it seems like the shallow_since for the other commit was also slightly earlier than the date of the commit. And if I use the date of the commit, I get Bazel build errors. Maybe @lx223 knows why this is so, or what the proper approach is?
Contributor
There was a problem hiding this comment.
shallow_since is about git history. As long as it is reasonably up-to-date, then it's fine.
benclive
approved these changes
Mar 11, 2019
benclive
left a comment
benclive
left a comment
There was a problem hiding this comment.
LGTM once the "shallow_since" is updated. This is basically all generated code.
blueberry-pi
force-pushed
the
COMP-673-spatiald-custom-runtime-ver
branch
from
084860d to
05780c1
Compare
blueberry-pi
force-pushed
the
COMP-673-spatiald-custom-runtime-ver
branch
2 times, most recently
from
adceefe to
4df5574
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating with the description and runtime_version fields that were added to the deployment proto. The runtime_version in particular is needed for feature parity with cloud Mercury.
(Also pulled in a bunch of documentation changes that were made)