Skip to content

[COMP-673] Add description and runtime version #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 13, 2019
Merged

[COMP-673] Add description and runtime version #26

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1039d3d
Add description and runtime version
blueberry-pi Mar 7, 2019
4df5574
Updated build queue
blueberry-pi Mar 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .buildkite/premerge.steps.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ common: &common
# TODO(EV): Make docs better. (https://github.com/improbable/platform/blob/master/docs/product-groups/dev-workflow/buildkite/how-to-deploy-change-to-agents.md)
- "capable_of_building=platform"
- "environment=production"
- "queue=v-ccadbedf01b84f29-------1540485662"
- "queue=v2-1545678177-378924f50bfed5a0-------z"
timeout_in_minutes: 60 # TODO(ENG-548): reduce timeout once agent-cold-start is optimised.
retry:
automatic:
Expand Down
4 changes: 2 additions & 2 deletions WORKSPACE
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,8 +61,8 @@ git_repository(
git_repository(
name = "improbable_platform",
remote = "git@github.com:improbable/platform.git",
commit = "246c6a1db4e352b51f4d2197cdf600077ab41bce",
shallow_since = "2018-12-01",
commit = "777672f36dbc103621ee04dec1786da2cdd48599",
shallow_since = "2019-02-01",
Copy link

@benclive benclive Mar 11, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not entirely sure what this date is, but it should probably be the date of the commit (13th Feb)?

Copy link
Contributor Author

@blueberry-pi blueberry-pi Mar 11, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought so too, but it seems like the shallow_since for the other commit was also slightly earlier than the date of the commit. And if I use the date of the commit, I get Bazel build errors. Maybe @lx223 knows why this is so, or what the proper approach is?

Copy link
Contributor

@lx223 lx223 Mar 12, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shallow_since is about git history. As long as it is reasonably up-to-date, then it's fine.

)

new_git_repository(
Expand Down
294 changes: 226 additions & 68 deletions apis/deployment_v1alpha1/Deployment.cs
View file
Open in desktop

Large diffs are not rendered by default.

270 changes: 15 additions & 255 deletions apis/deployment_v1alpha1/DeploymentGrpc.cs
View file
Open in desktop

Large diffs are not rendered by default.

164 changes: 99 additions & 65 deletions apis/playerauth_v2alpha1/PlayerAuth.cs
View file
Open in desktop

Large diffs are not rendered by default.

33 changes: 29 additions & 4 deletions apis/snapshot_v1alpha1/Snapshot.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -514,7 +514,9 @@ public string DeploymentName {
public const int PageSizeFieldNumber = 3;
private int pageSize_;
/// <summary>
/// The number of snapshots to provide in each page of the paginated results.
/// Optional. The number of snapshots to fetch in each page of the paginated results.
/// If provided, the `page_size` must be a positive integer. If omitted,
/// the default value of 20 is used.
/// </summary>
[global::System.Diagnostics.DebuggerNonUserCodeAttribute]
public int PageSize {
Expand All @@ -528,8 +530,7 @@ public int PageSize {
public const int PageTokenFieldNumber = 4;
private string pageToken_ = "";
/// <summary>
/// A token, previously provided by the service as a `next_page_token`, for retrieving additional
/// pages of paginated results.
/// Optional. An opaque token to identify the start of the paginated results.
/// </summary>
[global::System.Diagnostics.DebuggerNonUserCodeAttribute]
public string PageToken {
Expand Down Expand Up @@ -699,6 +700,9 @@ public ListSnapshotsResponse Clone() {
private static readonly pb::FieldCodec<global::Improbable.SpatialOS.Snapshot.V1Alpha1.Snapshot> _repeated_snapshot_codec
= pb::FieldCodec.ForMessage(10, global::Improbable.SpatialOS.Snapshot.V1Alpha1.Snapshot.Parser);
private readonly pbc::RepeatedField<global::Improbable.SpatialOS.Snapshot.V1Alpha1.Snapshot> snapshot_ = new pbc::RepeatedField<global::Improbable.SpatialOS.Snapshot.V1Alpha1.Snapshot>();
/// <summary>
/// By default, snapshots are sorted by creation time (descending).
/// </summary>
[global::System.Diagnostics.DebuggerNonUserCodeAttribute]
public pbc::RepeatedField<global::Improbable.SpatialOS.Snapshot.V1Alpha1.Snapshot> Snapshot {
get { return snapshot_; }
Expand Down Expand Up @@ -872,7 +876,7 @@ public string DeploymentName {
public const int IdFieldNumber = 3;
private string id_ = "";
/// <summary>
/// The identifier for the desired snapshot.
/// The identifier for the snapshot.
/// </summary>
[global::System.Diagnostics.DebuggerNonUserCodeAttribute]
public string Id {
Expand Down Expand Up @@ -1146,6 +1150,16 @@ public TakeSnapshotRequest Clone() {
/// <summary>Field number for the "snapshot" field.</summary>
public const int SnapshotFieldNumber = 1;
private global::Improbable.SpatialOS.Snapshot.V1Alpha1.Snapshot snapshot_;
/// <summary>
/// These fields are mandatory:
/// - `project_name`
/// - `deployment_name`
///
/// These fields are optional:
/// - `tags`
///
/// Other set values will be ignored.
/// </summary>
[global::System.Diagnostics.DebuggerNonUserCodeAttribute]
public global::Improbable.SpatialOS.Snapshot.V1Alpha1.Snapshot Snapshot {
get { return snapshot_; }
Expand Down Expand Up @@ -1358,6 +1372,17 @@ public UploadSnapshotRequest Clone() {
/// <summary>Field number for the "snapshot" field.</summary>
public const int SnapshotFieldNumber = 1;
private global::Improbable.SpatialOS.Snapshot.V1Alpha1.Snapshot snapshot_;
/// <summary>
/// These fields are mandatory:
/// - `project_name`
/// - `deployment_name`
/// - `checksum`
///
/// These fields are optional:
/// - `tags`
///
/// Other set values will be ignored.
/// </summary>
[global::System.Diagnostics.DebuggerNonUserCodeAttribute]
public global::Improbable.SpatialOS.Snapshot.V1Alpha1.Snapshot Snapshot {
get { return snapshot_; }
Expand Down
Loading