Run tests on PHP 8.5 too #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise --prefer-lowest tests fail on 8.5.
There was a problem hiding this comment.
Pull request overview
This PR adds PHP 8.5 support to the test suite by including it in the CI test matrix and updating the nette/tester dependency to a version that supports PHP 8.5.
- Added PHP 8.5 to the GitHub Actions test matrix
- Updated nette/tester requirement from ^2.4 to ^2.5.7 to ensure PHP 8.5 compatibility
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/php.yml | Adds PHP 8.5 to the test matrix for CI testing |
| composer.json | Updates nette/tester to ^2.5.7 for PHP 8.5 support |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also require Tester with PHP 8.5 support, otherwise
--prefer-lowesttests fail on 8.5.