Conversation
There was a problem hiding this comment.
Pull request overview
Adds configurability for the maximum fetched response size in the cURL-based fetcher and updates the README with additional fetching/DNS/signature-verification guidance.
Changes:
- Make the cURL fetcher’s maximum response length configurable via constructor parameter.
- Update README to document default User-Agent usage and maximum fetched file size configuration.
- Add README documentation about DNS lookups and signature verification caveats.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
src/Fetcher/HttpClients/SecurityTxtFetcherCurlClient.php |
Adds $maxResponseLength constructor option and uses it to truncate responses. |
README.md |
Documents User-Agent, max file size, DNS lookup behavior, and signature verification notes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
acf4bff to
762e91e
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
762e91e to
69dfff8
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
69dfff8 to
250f538
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Make the maxlength when fetching configurable
Docs update:
GNUPG_SIGSUM_KEY_MISSINGis fine