Skip to content

Max length configurable and docs update#85

Merged
spaze merged 4 commits intomainfrom
spaze/max-length-config
Apr 8, 2026
Merged

Max length configurable and docs update#85
spaze merged 4 commits intomainfrom
spaze/max-length-config

Conversation

@spaze
Copy link
Copy Markdown
Owner

@spaze spaze commented Apr 7, 2026

Make the maxlength when fetching configurable

Docs update:

  • Document the cURL client parameters (user agent, max length)
  • Document DNS lookups and timeouts
  • Document that the the trustworthiness of the key used to sign the file cannot be verified, meaning that GNUPG_SIGSUM_KEY_MISSING is fine

@spaze spaze self-assigned this Apr 7, 2026
Copilot AI review requested due to automatic review settings April 7, 2026 18:25
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds configurability for the maximum fetched response size in the cURL-based fetcher and updates the README with additional fetching/DNS/signature-verification guidance.

Changes:

  • Make the cURL fetcher’s maximum response length configurable via constructor parameter.
  • Update README to document default User-Agent usage and maximum fetched file size configuration.
  • Add README documentation about DNS lookups and signature verification caveats.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.

File Description
src/Fetcher/HttpClients/SecurityTxtFetcherCurlClient.php Adds $maxResponseLength constructor option and uses it to truncate responses.
README.md Documents User-Agent, max file size, DNS lookup behavior, and signature verification notes.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/Fetcher/HttpClients/SecurityTxtFetcherCurlClient.php
Comment thread src/Fetcher/HttpClients/SecurityTxtFetcherCurlClient.php
Comment thread README.md Outdated
Comment thread README.md Outdated
Comment thread README.md Outdated
@spaze spaze force-pushed the spaze/max-length-config branch from acf4bff to 762e91e Compare April 7, 2026 23:18
@spaze spaze requested a review from Copilot April 7, 2026 23:37
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread README.md Outdated
@spaze spaze force-pushed the spaze/max-length-config branch from 762e91e to 69dfff8 Compare April 7, 2026 23:42
@spaze spaze requested a review from Copilot April 7, 2026 23:43
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread tests/Fetcher/HttpClients/SecurityTxtFetcherCurlClientTest.phpt Outdated
@spaze spaze force-pushed the spaze/max-length-config branch from 69dfff8 to 250f538 Compare April 8, 2026 00:41
@spaze spaze requested a review from Copilot April 8, 2026 00:41
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@spaze spaze merged commit 799e511 into main Apr 8, 2026
10 checks passed
@spaze spaze deleted the spaze/max-length-config branch April 8, 2026 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants