Fix nits in OpenWhisk minio documentation#139
Merged
mcopik merged 1 commit intospcl:masterfrom Mar 22, 2023
Merged
Conversation
The `jq` command listed resulted in two separate JSON dictionaries in the output as opposed to modifying the `address` field (change `,` to `|`) and had missing quotes around the address. In addition, this commit rewords the reason for changing the address field to be a bit more explicit and gives a more concrete example (in a different IP prefix than the internal address for clarity) of how to determine the right address.
Contributor
Author
|
Closes #138 |
mcopik
approved these changes
Mar 22, 2023
Collaborator
|
@alevy Thanks so much! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
jqcommand listed resulted in two separate JSON dictionaries in the output as opposed to modifying theaddressfield (change,to|) and had missing quotes around the address.In addition, this commit rewords the reason for changing the address field to be a bit more explicit and gives a more concrete example (in a different IP prefix than the internal address for clarity) of how to determine the right address.