-
Notifications
You must be signed in to change notification settings - Fork 93
Update linting process and repair CI #241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Last release in 2022, it keeps throwing false positive errors and our CI was permamently broken
Previously we skipped regression.py and cache.py files because of wrong gitignore format
WalkthroughThis pull request enhances code quality and consistency by integrating a Black linter check into the CI pipeline and updating the linting script. It also refines file ignore patterns and dependency management. Several modules in the project have been reformatted for improved readability, including adjustments to function signatures and string formatting. These changes do not alter functionality but aim to ensure a more streamlined and maintainable codebase. Changes
Sequence Diagram(s)sequenceDiagram
participant Dev as Developer
participant CI as CircleCI
participant Lint as Linting Script
Dev->>CI: Push commit with changes
CI->>Lint: Trigger linting job
Lint->>Lint: Activate Python virtual environment
Lint->>Lint: Run Black in check mode on 'sebs' directory using .black.toml
Lint->>Lint: Execute flake8 linting
Lint->>CI: Return linting results
CI->>Dev: Report job status
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
We drop
flake8-blackbecause it has not been updated in a long time, and it kept our CI permanently broken. We also fixed.gitignore, since we were not lintingcache.pyandregression.py.Summary by CodeRabbit