Builtin Collective Communication Syntax#20
Open
nrmer wants to merge 28 commits into
Open
Conversation
reduce partially implemented (can translate back and forth + can separate compute blocks for the routing step)
…ollectives + adapt code
… (not fully functional)
luxfg
reviewed
Dec 19, 2024
Collaborator
luxfg
left a comment
There was a problem hiding this comment.
Overall good WIP, see comments :)
I also added some minor comments that I know you are aware of regarding the syntax, just so we don't forget.
luxfg
reviewed
Dec 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
extend lark language
add mulstream type
add optimization pass for mulstreams
code style changes
write documentation
write a test suite