Skip to content

Builtin Collective Communication Syntax#20

Open
nrmer wants to merge 28 commits into
mainfrom
collectives
Open

Builtin Collective Communication Syntax#20
nrmer wants to merge 28 commits into
mainfrom
collectives

Conversation

@nrmer
Copy link
Copy Markdown
Collaborator

@nrmer nrmer commented Dec 18, 2024

  • extend lark language

    • add mullstream
    • add routing description
  • add mulstream type

    • patch the existing functions to support the changed lark file
    • add new irnodes
    • add call to optimizations
  • add optimization pass for mulstreams

    • change data blocks
      • create communication pattern
        • support snake communication pattern
        • support grid communication pattern
        • support pipelined communication
        • refactor code to make it more readable and to use the same structure in all parts
      • non pipelined datablock creation
      • pipelined datablock creation (should already be implemented)
    • fix subgrid
      • non pipelined subgrid creation
      • pipelined subgrid creation
    • change compute blocks
      • add additional operations
        • summation
        • multiplication
      • non pipelined compute block changes
      • pipelined compute block changes for 1 element
      • support multiple elements in the pipelined case
      • make code more readable
      • support nested reduce statements
  • code style changes

    • add additional comments to code
    • make code easier to read
  • write documentation

    • document usage for the user
    • document how the code is built
  • write a test suite

    • add new test files
    • support all previous tests

@nrmer nrmer requested a review from luxfg December 18, 2024 20:39
@nrmer nrmer self-assigned this Dec 18, 2024
Copy link
Copy Markdown
Collaborator

@luxfg luxfg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall good WIP, see comments :)

I also added some minor comments that I know you are aware of regarding the syntax, just so we don't forget.

Comment thread samples/spatial/reduce.sptl Outdated
Comment thread samples/spatial/reduce.sptl Outdated
Comment thread irspec/docs/collective/collective.md Outdated
Comment thread irspec/docs/collective/collective.md
Comment thread samples/spatial/reduce.sptl Outdated
Comment thread spatialstencil/syntax/spatial_ir/irnodes.py Outdated
Comment thread spatialstencil/syntax/spatial_ir/irnodes.py Outdated
Comment thread spatialstencil/syntax/spatial_ir/irnodes.py Outdated
Comment thread spatialstencil/syntax/spatial_ir/irnodes.py Outdated
Comment thread spatialstencil/syntax/spatial_ir/language.lark Outdated
Comment thread samples/spatial/simple_reduce.sptl Outdated
@nrmer nrmer changed the title Collective Communication Support (WIP) Collective Communication Support Feb 14, 2025
@luxfg luxfg changed the title Collective Communication Support Builtin Collective Communication Syntax Apr 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants