eal_common_options.c:verify_perms(): remove per-thread object.#7
Open
nikitadanilov wants to merge 1 commit intospdk:spdk-21.05from
Open
eal_common_options.c:verify_perms(): remove per-thread object.#7nikitadanilov wants to merge 1 commit intospdk:spdk-21.05from
nikitadanilov wants to merge 1 commit intospdk:spdk-21.05from
Conversation
verify_perms() defines a 4KB TLS array last_dir_checked to avoid re-checking permissions on the same directory again. This array is added to the TLS of every thread in the process. This wastes memory (a bit, arguably) and makes it impossible to use fast 'initial-exec' tls model in shared libraries linked with spdk/dpdk. Fix: simply drop '__thread' qualifier, the code is only ever executed during single-threaded initialisation: rte_eal_init() -> eal_plugins_init() -> eal_dlopen() -> verify_perms(). Signed-off-by: Nikita Danilov <ndanilov@ddn.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
verify_perms() defines a 4KB TLS array last_dir_checked to avoid re-checking permissions on the same directory again.
This array is added to the TLS of every thread in the process. This wastes memory (a bit, arguably) and makes it impossible to use fast 'initial-exec' tls model in shared libraries linked with spdk/dpdk.
Fix: simply drop '__thread' qualifier, the code is only ever executed
during single-threaded initialisation: rte_eal_init() -> eal_plugins_init() -> eal_dlopen() -> verify_perms().