Crypto Algorithms List Properties Description #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Description of the properties of the merged list draft.
zvr
requested changes
Aug 7, 2025
| * Asymmetric-key algorithms, commonly known as public-key algorithms, use two related keys (i.e., a key pair) to perform their functions: a public key and a private key. The public key may be known by anyone; the private key should be under the sole control of the entity that “owns” the key pair. Even though the public and private keys of a key pair are related, knowledge of the public key cannot be used to determine the private key. | ||
| * Values: "Cryptographic-Hash-Function" , "Symetric-Key-Algorithm" or "Asymmetric-Key-Algorithm" | ||
|
|
||
| Note: the subclasses has been added to the cryptoClass property, separated by a "/" character from the class. This specific way to structure the subclasses is WIP. |
There was a problem hiding this comment.
If "Values" is a fixed set of 3 alternatives, there cannot be subclasses.
The easiest way would be to define something like cryptoSubClass as a separate string, arbitrary for now, to be defined maybe later.
Otherwise you have to explain here the actual structure of the allowed values.
There was a problem hiding this comment.
This ticket reflect the action to mitigate this comment #17
Co-authored-by: Alexios Zavras (zvr) <zvr+git@zvr.gr>
Addressed comments 1, 3 and 4 from @zvr
This was referenced Aug 18, 2025
cryptoSubClass property described, with additional notes since this property is not fully consolidated.
|
@zvr given that this is the first PR with reviews, I wonder if you are expecting me to resolve the comments or with the "request for review" is enough and you will be the one resolving the comments. |
8 tasks
Adapted the properties description to the new verion of the list: * Removed the AND operator and adapted the description to the selected yaml compatible way to express several values spdx#23 * Removed the TO operator and adapted the description to the selected yaml compatible way to express a range of values spdx#26
stevenc-stb
approved these changes
Sep 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the properties of the merged list draft. #8