Skip to content

Conversation

@meretp
Copy link
Collaborator

@meretp meretp commented Jan 27, 2023

fixes #449

I tried to add a test for this but as the builder and parser are quite nested and I couldn't really isolate this function, I gave up. If you think it is necessary to add a test here, I would simply adapt the testfile.

Signed-off-by: Meret Behrens meret.behrens@tngtech.com

Signed-off-by: Meret Behrens <meret.behrens@tngtech.com>
Copy link
Collaborator

@armintaenzertng armintaenzertng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix! :)

@meretp meretp merged commit f934ae2 into spdx:main Jan 27, 2023
@meretp meretp deleted the issue-449-fix-json-parser branch January 27, 2023 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fails to parse valid SPDX JSON file

2 participants