-
Notifications
You must be signed in to change notification settings - Fork 18
feat: add API endpoint to list/retrieve tool execution logs #1040
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 349336f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
| } | ||
| } | ||
|
|
||
| func (s *Service) ListToolExecutionLogs(ctx context.Context, payload *gen.ListToolExecutionLogsPayload) (res *gen.ListToolExecutionLogsResult, err error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: I had to rename these methods to ListToolExecutionLogs rather than just ListToolLogs because of conflicts with names of other endpoints for the service.
For consistency I'll update the name used in the repo queries as well in a separate PR (which are now called ListToolLogs).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tests here were redundant now that we have the broader service tests
server/design/toolmetrics/design.go
Outdated
|
|
||
| Meta("openapi:operationId", "listToolExecutionLogs") | ||
| Meta("openapi:extension:x-speakeasy-name-override", "listToolExecutionLogs") | ||
| Meta("openapi:extension:x-speakeasy-react-hook", `{"name": "ListToolExecutionLogs"}`) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| Meta("openapi:extension:x-speakeasy-react-hook", `{"name": "ListToolExecutionLogs"}`) | |
| Meta("openapi:extension:x-speakeasy-react-hook", `{"name": "ToolExecutionLogs"}`) |
will map to useToolExecutionLogs instead of useListToolExecutionLogs
server/design/toolmetrics/design.go
Outdated
| Enum("ASC", "DESC") | ||
| Default("DESC") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are these case insensitive? (prefer they're lowercase regardless)
- explicit error handling of incorrect params - lowercase DESC and ASC in pagination - change react name to follow convention
Creates the API to be able to query for tool logs.
Examples
Fetching next page: