chore: replace sso_connection_id with workos_id in queries and app code by qstearns · Pull Request #2246 · speakeasy-api/gram

qstearns · 2026-04-16T04:59:37Z

Remove all dependencies on sso_connection_id, there are no more dependencies on it and it seems to confuse humans and Claude alike. This PR changes behavior to target workos_id as a column instead of sso_connection_id. After we merge it, we should run the following data migration:

UPDATE organization_metadata
SET workos_id = sso_connection_id,
    updated_at = clock_timestamp()
WHERE sso_connection_id IS NOT NULL
  AND workos_id IS NULL;

There is a follow-up PR to drop the column. We first merge the behavior change and let it run for a couple days to avoid risks of data loss.

claude

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

_{Tip: disable this comment in your organization's Code Review settings.}

changeset-bot · 2026-04-16T04:59:42Z

🦋 Changeset detected

Latest commit: 2c5516b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
server	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel · 2026-04-16T04:59:43Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
gram-docs-redirect	Ready	Preview, Comment	Apr 17, 2026 2:33am

speakeasybot · 2026-04-16T22:21:35Z

🚀 Preview Environment (PR #2246)

Preview URL: https://pr-2246.dev.getgram.ai

Component	Status	Details	Updated (UTC)
✅ Database	Ready	Existing database reused	2026-04-17 02:38:59.
✅ Images	Available	Container images ready	2026-04-17 02:38:42.

_{Gram Preview Bot}

devin-ai-integration

Devin Review found 0 new potential issues.

View 3 additional findings in Devin Review.

devin-ai-integration

Devin Review found 0 new potential issues.

View 5 additional findings in Devin Review.

devin-ai-integration

Devin Review found 2 new potential issues.

View 4 additional findings in Devin Review.

devin-ai-integration · 2026-04-17T00:52:12Z

+type Organization struct {
+	ID                 string
+	Name               string
+	Slug               string
+	WorkosID           *string
+	UserWorkspaceSlugs []string
+}


📝 Info: Cache serialization compatibility with new Organization type

The CachedUserInfo.Organizations field changed from []auth.OrganizationEntry to []sessions.Organization. The Redis cache uses msgpack serialization (via go-redis/cache). Old cached entries have fields like SsoConnectionID and Projects that don't exist in the new type, while the new type has WorkosID which doesn't exist in old data. This is safe because msgpack (like JSON) ignores unknown fields and zero-initializes missing ones. WorkosID will be nil for old cached entries, which is acceptable since it's *string. The 15-minute cache TTL (server/internal/auth/sessions/types.go:12) means old entries will naturally expire quickly after deployment.

Was this helpful? React with 👍 or 👎 to provide feedback.

devin-ai-integration

Devin Review found 3 new potential issues.

View 4 additional findings in Devin Review.

devin-ai-integration · 2026-04-17T01:54:05Z

 			})
 		}

-		// write through organization metadata when not from cache to keep entries updated
-		// TODO: there may be a better place to do this
-		if !fromCache {
-			if _, err := s.orgRepo.UpsertOrganizationMetadata(ctx, orgRepo.UpsertOrganizationMetadataParams{
-				ID:              org.ID,
-				Name:            org.Name,
-				Slug:            org.Slug,
-				SsoConnectionID: conv.PtrToPGText(org.SsoConnectionID),
-				Whitelisted:     pgtype.Bool{Bool: false, Valid: false},
-			}); err != nil {
-				return nil, oops.E(oops.CodeUnexpected, err, "error upserting organization metadata").Log(ctx, s.logger)
-			}
-		}
-
 		organizations = append(organizations, &gen.OrganizationEntry{
 			ID:                 org.ID,
 			Name:               org.Name,
 			Slug:               org.Slug,
-			SsoConnectionID:    org.SsoConnectionID,
 			UserWorkspaceSlugs: org.UserWorkspaceSlugs,
 			Projects:           orgProjects,
 		})


📝 Info: Info method no longer upserts org metadata on cache miss — equivalent behavior

The Info method removed the !fromCache upsert loop that previously wrote org metadata on every cache miss. This is equivalent because GetUserInfo on cache miss calls GetUserInfoFromSpeakeasy → syncOrgsAndWorkOSIDs, which upserts all orgs. The old code's fromCache variable (now _ at line 295) was used to conditionally run the upsert. The new code achieves the same effect implicitly — org metadata is always upserted when fetching fresh data from the IDP.

Was this helpful? React with 👍 or 👎 to provide feedback.

devin-ai-integration · 2026-04-17T01:54:06Z

+---
+"server": patch
+---
+
+Remove the legacy column sso_connection_id


🚩 sso_connection_id column not dropped from schema despite changeset title

The changeset at .changeset/petite-cooks-like.md says 'Remove the legacy column sso_connection_id', but the database schema (server/database/schema.sql:54) still has the sso_connection_id column, and no migration drops it. The PR only removes code that WRITES to the column. The generated sqlc code (e.g., server/internal/organizations/repo/queries.sql.go:359) still scans sso_connection_id from SELECT * queries. This is likely intentional (gradual deprecation), but the changeset title is misleading. A follow-up migration will be needed to actually drop the column.

Was this helpful? React with 👍 or 👎 to provide feedback.

…ication code Introduce sessions.Organization as an internal type to decouple the cached user info from the Goa API surface. The Speakeasy IDP's workos_id field now flows through to organization_metadata.workos_id via the upsert. Removes sso_connection_id from the Goa OrganizationEntry design and cleans up the frontend reference. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

devin-ai-integration

Devin Review found 0 new potential issues.

View 8 additional findings in Devin Review.

qstearns requested a review from a team as a code owner April 16, 2026 04:59

claude bot reviewed Apr 16, 2026

View reviewed changes

qstearns mentioned this pull request Apr 16, 2026

mig: drop sso_connection_id column from organization_metadata #2247

Open

vercel bot deployed to Preview April 16, 2026 04:59 View deployment

qstearns force-pushed the drop-sso-connection-id/behavior branch from 6003dcd to c08599c Compare April 16, 2026 05:09

vercel bot deployed to Preview April 16, 2026 05:09 View deployment

vercel bot deployed to Preview April 16, 2026 05:14 View deployment

qstearns changed the title ~~fix: replace sso_connection_id with workos_id in queries and app code~~ chore: replace sso_connection_id with workos_id in queries and app code Apr 16, 2026

This comment was marked as resolved.

Sign in to view

adaam2 approved these changes Apr 16, 2026

View reviewed changes

qstearns force-pushed the drop-sso-connection-id/behavior branch from e7aac86 to bc914ea Compare April 16, 2026 21:37

vercel bot deployed to Preview April 16, 2026 21:37 View deployment

This comment was marked as resolved.

Sign in to view

qstearns force-pushed the drop-sso-connection-id/behavior branch from bc914ea to aee305f Compare April 16, 2026 22:18

qstearns requested a review from a team as a code owner April 16, 2026 22:18

vercel bot deployed to Preview April 16, 2026 22:19 View deployment

github-actions bot added the preview Spawn a preview environment label Apr 16, 2026

This comment has been minimized.

Sign in to view

This comment was marked as resolved.

Sign in to view

qstearns force-pushed the drop-sso-connection-id/behavior branch from aee305f to 54ccee2 Compare April 17, 2026 00:01

vercel bot deployed to Preview April 17, 2026 00:01 View deployment

devin-ai-integration bot reviewed Apr 17, 2026

View reviewed changes

qstearns force-pushed the drop-sso-connection-id/behavior branch from 54ccee2 to 729cb08 Compare April 17, 2026 00:29

vercel bot deployed to Preview April 17, 2026 00:29 View deployment

devin-ai-integration bot reviewed Apr 17, 2026

View reviewed changes

qstearns force-pushed the drop-sso-connection-id/behavior branch from 729cb08 to 0617c5f Compare April 17, 2026 00:44

vercel bot deployed to Preview April 17, 2026 00:44 View deployment

devin-ai-integration bot reviewed Apr 17, 2026

View reviewed changes

qstearns force-pushed the drop-sso-connection-id/behavior branch from 0617c5f to c89c02a Compare April 17, 2026 01:47

vercel bot deployed to Preview April 17, 2026 01:47 View deployment

devin-ai-integration bot reviewed Apr 17, 2026

View reviewed changes

qstearns force-pushed the drop-sso-connection-id/behavior branch from c89c02a to a8f75b1 Compare April 17, 2026 02:17

vercel bot deployed to Preview April 17, 2026 02:18 View deployment

This comment was marked as resolved.

Sign in to view

qstearns force-pushed the drop-sso-connection-id/behavior branch from a8f75b1 to 63acce0 Compare April 17, 2026 02:30

vercel bot deployed to Preview April 17, 2026 02:30 View deployment

qstearns force-pushed the drop-sso-connection-id/behavior branch from 63acce0 to 2c5516b Compare April 17, 2026 02:33

vercel bot deployed to Preview April 17, 2026 02:33 View deployment

devin-ai-integration bot reviewed Apr 17, 2026

View reviewed changes

qstearns merged commit 7b925e4 into main Apr 17, 2026
28 checks passed

qstearns deleted the drop-sso-connection-id/behavior branch April 17, 2026 02:40

github-actions bot locked and limited conversation to collaborators Apr 17, 2026

Conversation

qstearns commented Apr 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

claude bot left a comment

Choose a reason for hiding this comment

Claude Code Review

Uh oh!

changeset-bot bot commented Apr 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

vercel bot commented Apr 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

speakeasybot commented Apr 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🚀 Preview Environment (PR #2246)

Uh oh!

This comment has been minimized.

This comment was marked as resolved.

Uh oh!

devin-ai-integration bot left a comment

Choose a reason for hiding this comment

Uh oh!

devin-ai-integration bot left a comment

Choose a reason for hiding this comment

Uh oh!

devin-ai-integration bot left a comment

Choose a reason for hiding this comment

Uh oh!

devin-ai-integration bot Apr 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

devin-ai-integration bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

devin-ai-integration bot Apr 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

devin-ai-integration bot Apr 17, 2026

Choose a reason for hiding this comment

Uh oh!

This comment was marked as resolved.

Uh oh!

devin-ai-integration bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

qstearns commented Apr 16, 2026 •

edited

Loading

changeset-bot bot commented Apr 16, 2026 •

edited

Loading

vercel bot commented Apr 16, 2026 •

edited

Loading

speakeasybot commented Apr 16, 2026 •

edited

Loading

devin-ai-integration bot Apr 17, 2026 •

edited

Loading

devin-ai-integration bot Apr 17, 2026 •

edited

Loading