feat: fine-grained MCP tool selection UI and team access tab#2255
Merged
feat: fine-grained MCP tool selection UI and team access tab#2255
Conversation
Add a "Specific tools" option to the MCP scope picker that expands into a tabbed two-column drill-down interface for selecting individual tools per server. Includes search filtering, onWheel scroll workaround for Radix Sheet body scroll lock, and custom mode state tracking. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Bump spacing across the board to reduce cramped feeling: wider popover (550px), wider server column (160px), taller headers (h-10), roomier items (px-3 py-2), and override TabsList/TabsTrigger fixed heights with h-auto so padding is respected. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Rename scope picker tabs: All tools, By annotation, By HTTP method - Add httpMethod field to ToolEntry (Goa design, SQL, SDK pipeline) - Build HttpMethodGroupPanel with select-all checkboxes per method - Tab switching resets selections (tabs are mutually exclusive) - Add indeterminate (minus) state to Checkbox component - Auto-size tab widths with subtle dividers between them Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Track active custom tab (All tools / By annotation / By HTTP method) on RoleGrant - Restore custom mode and correct tab when editing a saved role - Clear resources/annotations when switching between Specific servers and Specific tools - Fix popover trigger bg, offset, animation, and width tweaks - Use square-asterisk icon for HTTP method tab Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Show full MCP URL (sans protocol) instead of server name in server list - Widen server pane to 240px and popover to 620px - Fix row height alignment between server and tool items - Increase tab bar vertical padding Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Add Team Access tab to MCP detail page showing per-member access levels - Fix annotation-based grants not saving: resolve annotations to compound tool IDs before persisting so the backend receives real resource IDs - Add tab detection on role re-edit: infer annotation/HTTP method/select tab from saved resource IDs by comparing against current tool data - Add grey header with expand button to MCP scope picker popover that opens a full-screen dialog for easier tool selection - Resolve SDK merge conflicts (version bump to 0.32.40) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…-connect-ui # Conflicts: # .speakeasy/workflow.lock # client/sdk/.speakeasy/gen.lock # client/sdk/.speakeasy/gen.yaml # client/sdk/jsr.json # client/sdk/package.json # client/sdk/src/lib/config.ts # server/gen/http/openapi3.json
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Add "By collection" tab with SquareLibrary icon to scope picker - Move expand toggle from header to footer with "Open in full screen" text - Widen popover to 620px in custom mode for 4 tabs - Make fullscreen dialog fill 85vh with flex layout - Replace close X with minimize button that returns to popover Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…fix oxfmt formatting Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
🦋 Changeset detectedLatest commit: feb6e14 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Collaborator
🚀 Preview Environment (PR #2255)Preview URL: https://pr-2255.dev.getgram.ai
Gram Preview Bot |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
- Regen Speakeasy TypeScript SDK to update esm/ declaration files - Fix ScopePickerPopover icon type (ElementType→ComponentType) to resolve className prop narrowing to never in TS 5.8 - Fix MCPTeamAccessTab ghost→tertiary Button variant (ghost not in design system) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
🚩 No tests added for new components and behavior
CONTRIBUTING.md states: 'Add tests for all new contributions. Coding agents and assistants are fantastically effective at this.' This PR adds substantial new UI components (MCPTeamAccessTab, AnnotationGroupPanel, HttpMethodGroupPanel, CollectionGroupPanel, ToolSelectionPanel) and complex logic (inferCustomTab) without any accompanying tests. While this is a guideline rather than a hard rule, the inferCustomTab heuristic and compound ID generation logic in particular would benefit from unit tests given their complexity and the bug found in HttpMethodGroupPanel.
Was this helpful? React with 👍 or 👎 to provide feedback.
Generated files were out of sync with design files, causing the git:porcelain check to fail in CI. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Resolve merge conflicts: - ScopePickerPopover.tsx: keep feature branch tools array - MCPDetails.tsx: keep both imports (MCPTeamAccessTab + useEnvironmentVariables) - SDK/generated files: take main's newer versions Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…up key - HttpMethodGroupPanel: use tool.name instead of tool.id for compound resource IDs, consistent with all other tabs (BUG-0002/0003) - CreateRoleDialog: gate initialization on scopesData && toolsetsData being loaded to prevent race with async queries (BUG-0001) - CreateRoleDialog: remove broken inferCustomTab HTTP-method heuristic that relied on UUID-vs-name distinction (ANALYSIS-0005) - toolset.go: fix pre-existing dedup seen-map key mismatch (ANALYSIS-0003) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Regenerate openapi3.json from Goa design files and SDK to include both main's changes and our branch's ToolEntry additions. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
simplesagar
approved these changes
Apr 21, 2026
…ion tab, feature flag - Change group header from <button> to <div role="button"> to avoid nesting Radix Checkbox <button> inside outer <button> (invalid HTML) - Remove shared scrollRef/onWheel from AnnotationGroupPanel, HttpMethodGroupPanel, CollectionGroupPanel — rely on native overflow-y-auto - Rewrite CollectionGroupPanel to fetch actual org-level collections instead of grouping by project (was showing wrong data) - Gate MCPTeamAccessTab behind gram-rbac feature flag and mcp:read scope Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
- Remove expandable tool lists from annotation, HTTP method, and collection panels — select broadly by category instead - Add className prop to ToolSelectionPanel for caller-controlled height - Fix dialog columns not filling height (add flex flex-col to TabsContent) - Add min-h-[200px] to all tab contents to prevent height jumping - Remove overflow-hidden from PopoverContent to avoid scroll interference - Add bg-background to fullscreen button footer Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Fix DescribeToolset seen-map: check used Name but stored ID.String(), so dedup never worked. Now stores Name to match the check. - Fix useState initializer capturing stale isRbacEnabled on first render. Added useEffect to re-validate #team-access hash when flag loads. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Duplicate of #2252.
httpMethodon theToolEntrytype in the API, generated types, and SDK (v0.32.41+)Test plan
httpMethodsurfaces on tools via the SDK and API response🤖 Generated with Claude Code