feat: collapse bar charts beyond N rows with expand-to-view-all#2345
Merged
feat: collapse bar charts beyond N rows with expand-to-view-all#2345
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: b44cda6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
alx-xo
changed the base branch from
main
to
alexm/age-1882-allow-charts-to-be-expanded
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
simplesagar
approved these changes
Apr 22, 2026
Base automatically changed from
alexm/age-1882-allow-charts-to-be-expanded
to
main
April 22, 2026 06:24
Collaborator
🚀 Preview Environment (PR #2345)Preview URL: https://pr-2345.dev.getgram.ai
Gram Preview Bot |
…eights across all charts
… rows with a "show more" link to expand the full dataset.
alx-xo
force-pushed
the
alexm/age-1906-feat-bar-charts-should-collapse
branch
from
342c7dc to
b44cda6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
COLLAPSED_BAR_CHART_MAX_ROWS(6) rows in the defaultview, with a "Show N more" link that triggers the existing full-expand
BAR_THICKNESS,BAR_ROW_HEIGHT,BAR_ROW_SPACER, andLINE_CHART_HEIGHTconstants so all chart dimensions arecontrolled from a single place
Root cause
Bar charts with large datasets (50+ servers or users) made the dashboard cards very tall and hard to scan. The existing expand
mechanism was already in place but wasn't being leveraged to hide excess rows — charts simply rendered everything at full height
regardless of how many entries there were.
Test plan
Visual
hooks-chart-cutoff.mp4