feat(plugins): allow publish with only the observability plugin#2610
Merged
Conversation
…ugin The Publish to GitHub button was hidden until a custom plugin existed, and the backend rejected publish when no custom plugins had servers. The observability plugin is always emitted on publish, so an org with none of its own plugins can still ship a meaningful marketplace. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
🦋 Changeset detectedLatest commit: cb779cb The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Collaborator
🚀 Preview Environment (PR #2610)Preview URL: https://pr-2610.dev.getgram.ai
Gram Preview Bot |
chase-crumbaugh
approved these changes
May 5, 2026
It asserted publish errors when no custom plugins exist; that path now succeeds (publishes only the observability plugin) and is covered by TestPublishPlugins_ObservabilityOnly. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hasPluginsguard on the Publish to GitHub button inclient/dashboard/src/pages/plugins/Plugins.tsx— it was hiding the button until a custom plugin existed, which contradicted the observability section's "Connect GitHub publishing to also ship it via the marketplace" copy.server/internal/plugins/impl.go("no plugins with servers to publish").GeneratePluginPackagesalways emits the per-org observability plugin and a one-entry marketplace whenHooksAPIKeyis set, which is always true on the publish path.TestPluginsService_PublishPlugins_ObservabilityOnlycovering the new "zero custom plugins" publish path.Test plan
go test ./internal/plugins/...(5.3s, all green including the new test)npx tsc --noEmitinclient/dashboard🤖 Generated with Claude Code