feat: cascade custom domain soft-deletes to mcp endpoints#2810
Merged
bflad merged 1 commit intoMay 21, 2026
Merged
Conversation
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
🦋 Changeset detectedLatest commit: ae00f2d The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Collaborator
🚀 Preview Environment (PR #2810)Preview URL: https://pr-2810.dev.getgram.ai
Gram Preview Bot |
This comment has been minimized.
This comment has been minimized.
Contributor
|
Found 1 test failure on Blacksmith runners: Failure
|
qstearns
approved these changes
May 21, 2026
Member
Author
|
rebasing and merging, thanks for the review @qstearns |
bflad
force-pushed
the
bflad-age-2228-cascade-custom-domain-soft-deletes-to-mcp_endpoints-5Cye
branch
from
6ff61b0 to
619c488
Compare
bflad
force-pushed
the
bflad-age-2228-cascade-custom-domain-soft-deletes-to-mcp_endpoints-5Cye
branch
from
619c488 to
6064816
Compare
bflad
force-pushed
the
bflad-age-2228-cascade-custom-domain-soft-deletes-to-mcp_endpoints-5Cye
branch
from
6064816 to
526adb1
Compare
https://linear.app/speakeasy/issue/AGE-2228/cascade-custom-domain-soft-deletes-to-mcp-endpoints - DeleteDomain soft-deletes child mcp_endpoints across every project under the org-scoped custom domain and emits one mcp-endpoint:delete audit event per row inside the existing transaction, mirroring the existing mcp_servers cascade. - Adds /rpc/domain.listMcpEndpoints (org:admin) returning endpoints joined with parent project and mcp_server for the dashboard delete-confirmation modal. /rpc/mcpEndpoints.list is project-scoped (mcp:read) and so can't preview a fan-out across other projects; the new endpoint lives on the domains service instead.
bflad
force-pushed
the
bflad-age-2228-cascade-custom-domain-soft-deletes-to-mcp_endpoints-5Cye
branch
from
526adb1 to
ae00f2d
Compare
bflad
deleted the
bflad-age-2228-cascade-custom-domain-soft-deletes-to-mcp_endpoints-5Cye
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://linear.app/speakeasy/issue/AGE-2228/cascade-custom-domain-soft-deletes-to-mcp-endpoints
DeleteDomainsoft-deletes childmcp_endpointsacross every project under the org-scoped custom domain and emits onemcp-endpoint:deleteaudit event per row inside the existing transaction, mirroring the existingmcp_serverscascade./rpc/domain.listMcpEndpoints(org:admin) returning endpoints joined with parent project andmcp_serverfor the dashboard delete-confirmation modal./rpc/mcpEndpoints.listis project-scoped (mcp:read) and so can't preview a fan-out across other projects; the new endpoint lives on thedomainsservice instead.