Skip to content

fix(dashboard): clear logs search via Escape or empty box, not just ×#3095

Closed
simplesagar wants to merge 1 commit into
mainfrom
sagar/age-2594-logs-search-clear
Closed

fix(dashboard): clear logs search via Escape or empty box, not just ×#3095
simplesagar wants to merge 1 commit into
mainfrom
sagar/age-2594-logs-search-clear

Conversation

@simplesagar
Copy link
Copy Markdown
Member

@simplesagar simplesagar commented May 29, 2026

What

Follow-up to #3093 (AGE-2594). On the MCP Server Logs page, the filter search bar could only be cleared by clicking the × button — pressing Escape or deleting the text out of the box left the results still filtered.

Why

LogFilterBar tracks the live searchInput separately from the parent's applied searchQuery (which drives the data fetch). They only sync on submit. The × button called onSearchSubmit("") to clear the applied query, but:

  • Escape only cleared the local input and reset the filter-builder flow — it never called onSearchSubmit, so the applied query lingered (and it was gated behind the popover being open).
  • Emptying the box updated searchInput to "" but never re-submitted, so searchQuery stayed set and results remained filtered until an explicit submit.

So × was the only way to actually clear the search — the same "stuck filter" class of bug as the parent ticket.

How

  • Escape in the key step now mirrors the ×: clears the input, resets the flow, and calls onSearchSubmit(""). In the operator step it still just cancels the in-progress filter build without touching an applied search.
  • Emptying the box in the key step now calls onSearchSubmit("") so results refresh as soon as the query is gone.

Clearing when nothing is applied is a no-op (searchQuery is already null → no refetch).

Scope

Frontend-only, single file. No backend, migration, or SDK changes.

Testing

  • tsc -p tsconfig.app.json --noEmit — clean.
  • eslint — clean.
  • Not yet click-tested against a live dashboard.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@simplesagar simplesagar requested review from a team as code owners May 29, 2026 00:03
@simplesagar simplesagar added the bug Something isn't working label May 29, 2026
@linear-code
Copy link
Copy Markdown

linear-code Bot commented May 29, 2026

AGE-2594

Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

Tip: disable this comment in your organization's Code Review settings.

@vercel
Copy link
Copy Markdown

vercel Bot commented May 29, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
gram-docs-redirect Ready Ready Preview, Comment May 29, 2026 12:08am

Request Review

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 29, 2026

⚠️ No Changeset found

Latest commit: c92100e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Re-trigger cubic

@simplesagar simplesagar changed the title fix(dashboard): clear logs search via Escape or empty box, not just × fix(dashboard): make logs search bars clearable via Escape / empty box May 29, 2026
@simplesagar simplesagar force-pushed the sagar/age-2594-logs-search-clear branch from 985d443 to c92100e Compare May 29, 2026 00:14
@simplesagar simplesagar changed the title fix(dashboard): make logs search bars clearable via Escape / empty box fix(dashboard): clear logs search via Escape or empty box, not just × May 29, 2026
@simplesagar
Copy link
Copy Markdown
Member Author

Superseded by #3096, which now bundles this LogFilterBar fix together with the shared SearchBar Escape-to-clear change.

@simplesagar simplesagar deleted the sagar/age-2594-logs-search-clear branch May 29, 2026 00:17
@github-actions github-actions Bot locked and limited conversation to collaborators May 29, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant