-
Notifications
You must be signed in to change notification settings - Fork 9
fix: improve openapi join conflict resolution and validation #45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Test Coverage ReportCurrent Coverage: Coverage Change: ✅ No change Coverage by Package
Generated by GitHub Actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
marshalling
Related to data marshalling/unmarshalling
openapi
Related to OpenAPI core functionality
validation
Related to validation logic
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses several critical issues in OpenAPI join functionality, conflict resolution, and validation. The changes improve the robustness of the library when handling complex OpenAPI document merging scenarios.
Changes Made
🔧 OpenAPI Join Improvements
🛠️ Core Fixes
sequencedmap/map.goopenapi/responses.goResolvableinterface implementationmarshaller/unmarshaller.go📋 Test Data Updates
Files Changed
openapi/join.go(+197 lines) - Major enhancements to join functionalitysequencedmap/map.go- Fixed ordered iterationopenapi/responses.go- Validation improvementsjsonschema/oas3/resolution.go- Enhanced resolution logicreferences/resolution.go- Interface improvementsTesting
Breaking Changes
None - all changes are backward compatible.
Related Issues
Addresses various edge cases in OpenAPI document joining and validation that could lead to incorrect behavior in complex scenarios.