-
Notifications
You must be signed in to change notification settings - Fork 9
fix: handle chained header references in bundle command #83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
📊 Test Coverage ReportCurrent Coverage: Coverage Change: 📉 -.2% (decreased) Coverage by Package
📋 Detailed Coverage by Function (click to expand)
Generated by GitHub Actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #72 - Bundle command now correctly handles chained header references across multiple external files.
Problem
When bundling OpenAPI documents with chained references (e.g.,
testapi.yaml → common.yaml → headers.yaml), headers were being duplicated because the bundler didn't recognize that different reference paths ultimately point to the same component.Solution
Added reference chain following to properly deduplicate chained references:
getFinalAbsoluteRef()function to follow reference resolution chains to the final absolute referencegetFinalResolutionInfo()function to get final resolution info for nested bundlingbundleGenericReference()to map both intermediate and final reference paths to the same component nameChanges
openapi/bundle.go: Added chain-following logic for proper deduplicationopenapi/testdata/bundle/issue50/: Added header reference test caseTesting
mise ci)