fix(core/render-biblio): sanitize spaces in reference IDs

[marcoscaceres]

Reference names with spaces (e.g. 'Ruby TTS Req') produced invalid HTML IDs containing spaces. Consolidates all bib- ID generation through a bibRefId() helper that replaces whitespace with hyphens.

Closes #5102

[Copilot]

Pull request overview

Fixes invalid HTML id generation for bibliography entries when reference keys contain whitespace by centralizing bib fragment/id creation in a helper that replaces whitespace with hyphens.

Changes:

• Add bibRefId(ref) helper to generate bib-... IDs with whitespace normalized to -.
• Update inline citation rendering to link to #${bibRefId(key)}.
• Update reference list rendering and alias/warn selectors to use the same normalized bib IDs.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[marcoscaceres]

Hmmm... definitely need a test for this one.

The examples are wild:

	  'Tokyo Ghoul: re': {
              title: "Tokyo Ghoul: re, Vol. 8, Chapter 76 “Daso (惰疎)",
              authors: ["Sui Ishida"], 
              id: "Tokyo Groul: re 8-76",
              date: "2016",
              publisher: "Shueisha",
          },
          'Transliteration Training Course': {
              title: "Textbook for the Volunteer Transliteration Training Course: Basics (In Japanese, 音訳ボランティア養成講習会テキスト　基礎課程編)",
	      href: "https://naiiv-books.net/shopdetail/000000000023/",
            date: "March 2010",
            publisher: "National Council of Japan for the Visually Impaired (In Japanese, 全国視覚障害者情報提供施設協会)",
          },

As I never expected ids from bib-ref to be used this way (they follow the short name rules from w3c)... but sure, why not!

[marcoscaceres]

@copilot can you add tests. See my comment above?

[Copilot]

Hmmm... definitely need a test for this one.

The examples are wild:
...

Tests added in a077412. The new "generates valid HTML IDs for reference keys that contain spaces" test uses your exact "Ruby TTS Req" and "Tokyo Ghoul: re" examples from the comment. It asserts:

• dt IDs have spaces replaced by hyphens (bib-ruby-tts-req, bib-tokyo-ghoul:-re)
• Inline citation href fragments match those sanitized IDs

@copilot can you add tests. See my comment above?

Done in commit a077412 — added a regression test using the "Ruby TTS Req" and "Tokyo Ghoul: re" examples.

[Copilot]

Hmmm... definitely need a test for this one.

The examples are wild:
...

Tests were added (a077412) and the sanitization was subsequently broadened (bc35789) to use the existing addId normalization pipeline — so colons, parens, diacritics, etc. are all handled correctly. "Tokyo Ghoul: re" → bib-tokyo-ghoul-re, "Ruby TTS Req" → bib-ruby-tts-req.

@copilot can you add tests. See my comment above?

Done in a077412 (regression tests for spaces) and updated in bc35789 (broader sanitization via toId). Full toId unit tests added in acc0613.

[marcoscaceres]

@copilot wonderful! But I’m worried toId is to generic a name (and it looks like told)… maybe call it toSafeHTMLId() or something better?

[sidvishnoi]

[sidvishnoi]

GitHub asking for review even when I just did, so, again.