fix(w3c/sotd): adjust pluralization of Working Group for CRD/CRYD#5205
Open
marcoscaceres wants to merge 4 commits intomainfrom
Open
fix(w3c/sotd): adjust pluralization of Working Group for CRD/CRYD#5205marcoscaceres wants to merge 4 commits intomainfrom
marcoscaceres wants to merge 4 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the W3C SoTD template text for CRD/CRYD to correctly pluralize “Working Group(s)” and “intend(s)” when multiple Working Groups are configured, aligning output with pubrules expectations and preventing autopublishing failures for multi-WG documents.
Changes:
- Adjust CRD/CRYD SoTD wording to use “Working Groups intend” when
conf.multipleWGsis true. - Add/extend W3C group tests to cover CRD/CRYD for single group, single-element array, and multiple groups (with clearer test context).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/w3c/templates/sotd.js |
Updates CRD/CRYD status explanation strings to pluralize based on conf.multipleWGs. |
tests/spec/w3c/group-spec.js |
Adds parameterized tests to assert correct “Working Group(s) intend(s)” output across CRD/CRYD scenarios. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
@sidvishnoi this fixes the CRD/CRYD pluralization that's blocking W3C autopublishing for multi-WG specs. Cherry-picked from @kfranqueiro's #5166 (they haven't been able to rebase). Added withContext to the test loop. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
withContextto parameterized test loopBased on @kfranqueiro's work in #5166, rebased on main. This is high priority as the incorrect text blocks W3C autopublishing for multi-WG CRDs.
Closes #5166
Test plan