Skip to content

fix(w3c/sotd): adjust pluralization of Working Group for CRD/CRYD#5205

Open
marcoscaceres wants to merge 4 commits intomainfrom
fix/5166-pluralization
Open

fix(w3c/sotd): adjust pluralization of Working Group for CRD/CRYD#5205
marcoscaceres wants to merge 4 commits intomainfrom
fix/5166-pluralization

Conversation

@marcoscaceres
Copy link
Copy Markdown
Contributor

Summary

  • Pluralizes "Working Group" to "Working Groups" and "intends" to "intend" when multiple WGs are listed in CRD/CRYD SoTD
  • Handles single-element arrays correctly
  • Adds withContext to parameterized test loop

Based on @kfranqueiro's work in #5166, rebased on main. This is high priority as the incorrect text blocks W3C autopublishing for multi-WG CRDs.

Closes #5166

Test plan

  • Tests cover single group, single-group-in-array, and multiple groups for both CRD and CRYD

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the W3C SoTD template text for CRD/CRYD to correctly pluralize “Working Group(s)” and “intend(s)” when multiple Working Groups are configured, aligning output with pubrules expectations and preventing autopublishing failures for multi-WG documents.

Changes:

  • Adjust CRD/CRYD SoTD wording to use “Working Groups intend” when conf.multipleWGs is true.
  • Add/extend W3C group tests to cover CRD/CRYD for single group, single-element array, and multiple groups (with clearer test context).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/w3c/templates/sotd.js Updates CRD/CRYD status explanation strings to pluralize based on conf.multipleWGs.
tests/spec/w3c/group-spec.js Adds parameterized tests to assert correct “Working Group(s) intend(s)” output across CRD/CRYD scenarios.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@marcoscaceres
Copy link
Copy Markdown
Contributor Author

@sidvishnoi this fixes the CRD/CRYD pluralization that's blocking W3C autopublishing for multi-WG specs. Cherry-picked from @kfranqueiro's #5166 (they haven't been able to rebase). Added withContext to the test loop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants