fix: revert Iterator helpers to array spread for browser compat#5259
Merged
marcoscaceres merged 2 commits intoMay 6, 2026
Conversation
`.keys().find()` on Set/Map iterators requires the ES2025 Iterator Helpers proposal (Chrome 117+, Firefox 131+, Safari 18+). In browsers without support, these throw TypeError, breaking variable highlighting and case-insensitive reference lookups. Revert to `[...keys()].find()` which works in all browsers ReSpec targets. Closes speced#5255
Contributor
There was a problem hiding this comment.
Pull request overview
This PR restores browser compatibility by avoiding ES2025 Iterator Helpers usage (.keys().find()) on Set/Map iterators, which can throw in older browsers and break variable highlighting and case-insensitive key lookups.
Changes:
- Replace iterator helper usage with array spread +
find()inInsensitiveStringSet.getCanonicalKey(). - Replace
Map.prototype.keys().find(...)with[...keys()].find(...)in runtime variable highlighting.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/core/utils.js | Switches iterator .find() to [...this.keys()].find() for case-insensitive canonical key lookup. |
| src/core/highlight-vars.runtime.js | Switches iterator .find() to [...HL_COLORS.keys()].find() to keep highlight color selection working in older browsers. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
@copilot Can you confirm all your feedback has been addressed? Can you fix anything that was not addressed? |
sidvishnoi
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5255
.keys().find()on Set/Map iterators requires the ES2025 Iterator Helpers proposal (Chrome 117+, Firefox 131+, Safari 18+). In browsers without support, these throw TypeError, breaking variable highlighting (highlight-vars.runtime.js) and case-insensitive reference lookups (utils.js).Reverts to
[...keys()].find()which works in all browsers ReSpec targets. Introduced in the TypeScript 6 upgrade (#5169).