fix(w3c/headers): derive /TR pubSpace for multi-group specs#5263
Merged
marcoscaceres merged 3 commits intoMay 5, 2026
Merged
Conversation
When `group` is an array (e.g., `["das", "webapps"]`), `conf.groupType` becomes an array like `["wg", "wg"]`. The strict equality check `conf.groupType === "wg"` always fails for arrays, so `derivePubSpace` returned undefined, producing an incorrect `latestVersion`. Now checks both string and array forms of `groupType`. Closes speced#4688
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes incorrect W3C /TR/ publication-space derivation for multi-group specs, ensuring the “Latest published version” URL is generated correctly when groupType is an array.
Changes:
- Update
derivePubSpace()to treatconf.groupTypeas either a string or an array. - Determine “is working group” via
groupType === "wg"orgroupType.includes("wg")(when array), enabling/TR/derivation for multi-group configs.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Verifies that when group is an array (e.g., ["das", "webapps"]) with specStatus "ED", the latestVersion correctly resolves to /TR/<shortName>/. Address Copilot feedback.
Contributor
Author
|
@copilot Can you confirm all your feedback has been addressed? Can you fix anything that was not addressed? |
1 similar comment
Contributor
Author
|
@copilot Can you confirm all your feedback has been addressed? Can you fix anything that was not addressed? |
jyasskin
reviewed
May 4, 2026
sidvishnoi
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4688
When
groupis an array (e.g.,["das", "webapps"]),conf.groupTypebecomes an array like["wg", "wg"]. The strict equality checkconf.groupType === "wg"always fails for arrays, soderivePubSpacereturnedundefined, producing an incorrect or emptylatestVersion.Now checks both string and array forms of
groupType.Visually verified in Safari with
group: ["das", "webapps"], specStatus: "ED", shortName: "geolocation": "Latest published version" correctly showshttps://www.w3.org/TR/geolocation/.