Nested Query Builder Can Not Create All Items CSV

[carlosmbe]

Describe the bug
If you open the Query Builder from let's say Data Entry and try to create a CSV from the query you just built. It will not export. I also tested this on the new Selected Query Branch and they work fine.

To Reproduce
Steps to reproduce the behavior:

1. Go to Data Entry -> Taxon -> Parent of Taxon
2. Click on the search on the side
3. Enter Query Builder
4. Run something and click on Create CSV
5. See Error

Expected behavior
It is exported without an issue.

Beautiful Screen Recording

Compressed.Nested.Issue.mp4

[maxpatiiuk]

The dialog says "A notification will appear when the export file is complete and ready for download"

Does the notification appear after a while in the side menu? If yes this is working as expected

[carlosmbe]

@maxpatiiuk It does not.

[maxpatiiuk]

Weird. The export mechanism shouldn't be affected by query being nested. Are you sure this works correctly when the query builder is not in a dialog but opened standalone?

[CarolineDenis]

Confirm that the export doesn't work in a dialog but does in stand alone.
(The payload for the doQuery() API route is correct )

[maxpatiiuk]

weird. when someone fixes this, could you assign me on the PR for review? I am just curious what's going on here

[CarolineDenis]

The backend query fails because the key 'fields' is not present in the serialized resource.

[CarolineDenis]

Findings and potential solution:

• When exporting query result we need the fields from the queryResource.toJSON() (line 53 in Export.tsx)

• The fields are set only if the condition typeof getQueryFieldRecords === 'function' is true.

• getQueryFieldRecords is a function if the variable saveRequired is true otherwise it's undefined. (line 184 in Wrapped.tsx)

• saveRequired depends on 3 conditions: const saveRequired =

  (isResourceModified || state.saveRequired) && !isEmbedded; (line147 in Wrapped.tsx)

• if we take off the condition " !isEmbedded " from the saveRequired variable, the export works finally.

===> @maxpatiiuk do you remember why you had that extra condition there or can we take it off in order for the export to work?