Error message when deleting tree ranks that have associated nodes

[Areyes42]

Describe the bug
A brief error message appears when attempting to delete tree ranks associated with a node via the Storage Tree Def Items menu.

To Reproduce
Steps to reproduce the behavior:

1. Go to a tree
2. Click on the edit pencil next to the tree name
3. Click the 'Tree Def Items' button
4. Try deleting a rank with nodes
5. Save
6. See error

Expected behavior
When attempting to delete a tree rank that has associated nodes, a save blocker should be enforced, similar to the mechanism used when deleting with the pencil button.

Screenshots

Screen.Recording.2024-06-20.at.1.56.16.PM.mp4

Please, also fill out the following information manually:

• OS: macOS 14.5
• Browser: Chrome
• Specify 7 Version: Edge & PR Add DO_NOTHING for on_delete on TreeDefItems #5024
• Database Name: KUFish_5_16_23
• Collection name: KU Fish Voucher
• User Name: spfishadmin

[acwhite211]

Ya good catch, the error dialog that pops up before refreshing the page has always been happening. There isn't any problems with add/deleting the ranks. The pop up is just hard to debug on the front-end because the page refreshes so quickly. It's probably not a real issue for 7.9.6.

[realVinayak]

@acwhite211 You'll need to confirm, but it very likely chokes below

specify7/specifyweb/specify/api.py

Line 636 in c62b400

to_delete.delete()

Set a breakpoint below for that.

specify7/specifyweb/specify/api.py

Line 635 in c62b400

auditlog.remove(rel_obj, agent, obj)

I think it is a real bug, but one that maybe non-trivial to fix.

Was going to work on fixing the refresh bug, but didn't get time. For now, comment out this line (or well, remove the reload call)

specify7/specifyweb/frontend/js_src/lib/components/TreeView/Tree.tsx

Line 272 in c62b400

onSaved={(): void => globalThis.location.reload()}

[realVinayak]

The root of the bug is not specific to tree ranks (any place that deletes dependent to-many will have that bug). For now, showing the error dialog. Will be useful for future anyways (to get crash report or pretty format the dialog)

[emenslin]

Can recreate in edge (7.9.6)