'Division' field name and picklist items missing

[yvonneekanim]

The division field caption and information in accession form doesn't show up

[maxpatiiuk]

Seems like a forms issue

[benanhalt]

It's not a forms issue.There the division picklist is a special case that hasn't been implemented.

[maxpatiiuk]

Added a special case for DivisionCBX in daed12a
@benanhalt though, that did not fix the missing field label issue. Does that case have to be handled in localizeform.js?

It seems to be set to (whitespace) in the form definition

[benanhalt]

Yes. It seems there will need to be a special case in localizeform.js. It should detect the cell id being divLabel and in that case it should use the localized name of the division table.

This is based on the Specify 6 code at https://github.com/specify/specify6/blob/fd30b3f64c0faab9a4fcc5c45eebc5cb61905920/src/edu/ku/brc/specify/datamodel/busrules/AccessionBusRules.java#L225-L229

[benanhalt]

It should probably also check that it is localizing an Accession form so that it doesn't mess up if someone uses "divLabel" on a different form. I would do the special case just above

specify7/specifyweb/frontend/js_src/lib/localizeform.js

Line 35 in aa7d05c

var forId = label.prop('for');

. The variable `model which is in scope at that point should allow it determine if it is doing an Accession form.

[maxpatiiuk]

I am not sure I quite get it. Where do I get the current cell name from? The label at this line is equal to <label> </label> (doesn't have a for prop). And then it returns at this line.

I only have access to the cell variable at this point. Though, there is no way of getting the table name here

[benanhalt]

Okay. I see what you mean. In specifyformcells.js you need to add a property to the element it is creating to hold the id attribute from the cell element from the form definition. I would use something like data-specify-label-id rather than id. Then you will be able to inspect that attribute in localizeform.js to see if it is equal to "divLabel" and if model is an Accession object. As for the early return because the label has text. Change the test to check if the text is all white space. That way the label can still be hard coded in the form definition.

[maxpatiiuk]

Fixed in 50eab0d
Ready for testing on the issue-735 branch