Skip to content

Respect naming convention for new geo tables#5221

Merged
CarolineDenis merged 5 commits intoproductionfrom
issue-5175
Aug 14, 2024
Merged

Respect naming convention for new geo tables#5221
CarolineDenis merged 5 commits intoproductionfrom
issue-5175

Conversation

@CarolineDenis
Copy link
Copy Markdown
Contributor

@CarolineDenis CarolineDenis commented Aug 13, 2024

Fixes #5175
Fixes #5192

Checklist

  • Self-review the PR after opening it to make sure the changes look good
    and self-explanatory (or properly documented)
  • Add relevant issue to release milestone

Testing instructions

Verify this is fixed:
#5192
#5175

@realVinayak
Copy link
Copy Markdown
Contributor

@CarolineDenis could you resolve the import for tests?

@CarolineDenis CarolineDenis marked this pull request as ready for review August 14, 2024 14:23
@CarolineDenis CarolineDenis requested review from a team and sharadsw August 14, 2024 17:09
@realVinayak realVinayak requested a review from a team August 14, 2024 17:25
Copy link
Copy Markdown
Collaborator

@combs-a combs-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verify this is fixed:

Looks like it's fixed 5175, but I can't tell for 5192 since I wasn't able to recreate the issue on my end for edge. I had to refresh/clear cache, but otherwise they were appearing just fine on both queries and forms

For 5175:
https://github.com/user-attachments/assets/1f7fa96f-b9d6-489a-ad02-06e21cfe73d1

Copy link
Copy Markdown
Collaborator

@lexiclevenger lexiclevenger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing instructions

Verify this is fixed:


It seems like #5175 is fixed in this branch but #5192 is not:

#5175:
Screenshot 2024-08-14 at 1 22 26 PM

#5192:
Screenshot 2024-08-14 at 1 35 08 PM

Copy link
Copy Markdown
Contributor

@alesan99 alesan99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing instructions

Verify this is fixed:

5175 is fixed, and after migrations 5192 is fixed for me too 👍

Validation:
chrome_FbLmSVYLQn

Schema Config changes:
chrome_8s2kCAO7Nf

Copy link
Copy Markdown
Collaborator

@combs-a combs-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was able to recreate the 5192 on database that ChadronTest2 was based on, ChadronTest, so the migrations should have fixed the issue 👍

@lexiclevenger lexiclevenger dismissed their stale review August 14, 2024 19:02

Did not run migration

@CarolineDenis CarolineDenis merged commit 1419cd7 into production Aug 14, 2024
@CarolineDenis CarolineDenis deleted the issue-5175 branch August 14, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅Done

Development

Successfully merging this pull request may close these issues.

Schema labels and configuration are not being respected with new tables Fix workbench validation for CollectionObjectType

6 participants