Respect naming convention for new geo tables#5221
Merged
CarolineDenis merged 5 commits intoproductionfrom Aug 14, 2024
Merged
Conversation
3 tasks
Contributor
|
@CarolineDenis could you resolve the import for tests? |
realVinayak
approved these changes
Aug 14, 2024
sharadsw
approved these changes
Aug 14, 2024
combs-a
reviewed
Aug 14, 2024
Collaborator
There was a problem hiding this comment.
Verify this is fixed:
Looks like it's fixed 5175, but I can't tell for 5192 since I wasn't able to recreate the issue on my end for edge. I had to refresh/clear cache, but otherwise they were appearing just fine on both queries and forms
For 5175:
https://github.com/user-attachments/assets/1f7fa96f-b9d6-489a-ad02-06e21cfe73d1
combs-a
approved these changes
Aug 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Fixes #5175
Fixes #5192
Checklist
and self-explanatory (or properly documented)
Testing instructions
Verify this is fixed:
#5192
#5175