Remove cat number format check in interaction dialog#6306
Merged
CarolineDenis merged 6 commits intoproductionfrom Mar 13, 2025
Merged
Remove cat number format check in interaction dialog#6306CarolineDenis merged 6 commits intoproductionfrom
CarolineDenis merged 6 commits intoproductionfrom
Conversation
sharadsw
approved these changes
Mar 7, 2025
sharadsw
reviewed
Mar 10, 2025
Contributor
sharadsw
left a comment
sharadsw
left a comment
There was a problem hiding this comment.
When I enter a catalog number with format 2025-000001 it gets parsed to 000000002 and all the preps shown are of 000000002
sharadsw
approved these changes
Mar 12, 2025
emenslin
approved these changes
Mar 12, 2025
Collaborator
emenslin
left a comment
emenslin
left a comment
There was a problem hiding this comment.
- Verify that you are directed to the prep dialog selection If the CO has preps
- Verify that a message "no prep found for this cat num" is displayed If the CO has no preps or even doesn't exist
Looks good, I tried on multiple interactions including loan, gift, disposal, and exchange out.
lexiclevenger
approved these changes
Mar 12, 2025
Collaborator
lexiclevenger
left a comment
lexiclevenger
left a comment
There was a problem hiding this comment.
Testing instructions
- Go to Interactions and choose Loan
- Choose the option "By entering catalog numbers"
- Enter a catalog number that is using a COT with a non-default catalog number
- Click Next
- Verify that you are directed to the prep dialog selection If the CO has preps
- Verify that a message "no prep found for this cat num" is displayed If the CO has no preps or even doesn't exist
Looks great!
acwhite211
approved these changes
Mar 13, 2025
github-project-automation
bot
moved this from 📋Back Log
to ✅Done
in General Tester Board
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6287
Checklist
self-explanatory (or properly documented)
Testing instructions
Notes:
Since we now allow multiple catalog number formats within the same collection using the collection object type, we can no longer determine which type of CO corresponds to the catalog number entered in the interaction dialog.
As a result, checking whether the catalog number follows the default collection format is no longer necessary for collections having multiple COType cat number format. Therefore, that check and the error message for catalog number format will be displayed only for collections that have a single cat number format COType.
For collections having several COTypes the parser will not be used anymore which means that to fins cat num 000001 entering only 1 will not work the user has to enter the entire format