Fix: replace legacy table icons with SvgIcon#7429
Merged
Conversation
Triggered by fa2beee on branch refs/heads/issue-6504-1
4 tasks
grantfitzsimmons
requested changes
Sep 20, 2025
github-project-automation
bot
moved this from 📋Back Log
to Dev Attention Needed
in General Tester Board
Triggered by dbbb1dc on branch refs/heads/issue-6504-1
Contributor
|
The wrong icon is being used too |
Triggered by 8ff13d7 on branch refs/heads/issue-6504-1
emenslin
approved these changes
Sep 26, 2025
Collaborator
emenslin
left a comment
emenslin
left a comment
There was a problem hiding this comment.
- Right-click a cell in the uploaded dataset to check the link uses the SvgIcon table icon.
- Open Batch Edit on the same dataset and check same SvgIcon appears.
Looks good!
09-26_12.33.mp4
lexiclevenger
approved these changes
Oct 3, 2025
Collaborator
lexiclevenger
left a comment
lexiclevenger
left a comment
There was a problem hiding this comment.
- Right-click a cell in the uploaded dataset to check the link uses the SvgIcon table icon.
- Open Batch Edit on the same dataset and check same SvgIcon appears.
Looks good! The correct icons are used
grantfitzsimmons
approved these changes
Oct 8, 2025
Member
grantfitzsimmons
left a comment
grantfitzsimmons
left a comment
There was a problem hiding this comment.
- Right-click a cell in the uploaded dataset to check the link uses the SvgIcon table icon.
- Open Batch Edit on the same dataset and check same SvgIcon appears.
CarolineDenis
approved these changes
Oct 8, 2025
Iwantexpresso
approved these changes
Oct 10, 2025
Contributor
Iwantexpresso
left a comment
Iwantexpresso
left a comment
There was a problem hiding this comment.
- Right-click a cell in the uploaded dataset to check the link uses the SvgIcon table icon.
it looks good to me!
- Open Batch Edit on the same dataset and check same SvgIcon appears.
github-project-automation
bot
moved this from Dev Attention Needed
to ✅Done
in General Tester Board
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6504
Replaced legacy Specify 6-style icons in WorkBench/Batch Edit result-cell links with standardized svgIcons assets. This ensures consistent icon usage across the app while avoiding reliance on outdated LegacyNonJSXIcons. The bug was caused by injecting raw SVG (Sp-6 styled) icons; the fix uses renderToStaticMarkup with our current icon set so visuals stay aligned without breaking existing DOM logic.
Checklist
self-explanatory (or properly documented)
Testing instructions