Fix: Cloning now correctly copies COA values when default COA creation is enabled.#7538
Merged
CarolineDenis merged 3 commits intomainfrom Nov 25, 2025
Merged
Fix: Cloning now correctly copies COA values when default COA creation is enabled.#7538CarolineDenis merged 3 commits intomainfrom
CarolineDenis merged 3 commits intomainfrom
Conversation
grantfitzsimmons
approved these changes
Nov 18, 2025
Member
There was a problem hiding this comment.
Before requesting review, can you make sure to check this?
- Self-review the PR after opening it to make sure the changes look good and
self-explanatory (or properly documented)
- Verify that cloning a Collection Object with existing COA values retains those values in the cloned record instead of creating a blank attribute irrespective of CO_CREATE_COA in remote preferences.
Left is main, right is issue-4825. I was able to recreate the issue on main. Works great!
Screen.Recording.2025-11-18.at.15.55.15.mov
CarolineDenis
approved these changes
Nov 19, 2025
Triggered by d921cd4 on branch refs/heads/issue-4825
emenslin
approved these changes
Nov 19, 2025
Collaborator
emenslin
left a comment
There was a problem hiding this comment.
- Verify that cloning a Collection Object with existing COA values retains those values in the cloned record instead of creating a blank attribute irrespective of CO_CREATE_COA in remote preferences.
Looks good, COA is properly cloned!
acwhite211
approved these changes
Nov 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4825
Cloning a Collection Object with CO_CREATE_COA_* enabled was creating a new blank CollectionObjectAttribute instead of preserving the original attribute values, which meant cloned COs did not produce an exact copy. The fix updates the auto-creation logic in scoping.ts to only generate a new COA when the record is newly created and has no existing attribute, while skipping COA creation during clone operations. As a result, cloned COs now retain their original CollectionObjectAttribute values, and new COs still automatically receive a COA when appropriate.
Note : Observed in tag v7.10.0; not reproducible on main. Please advise backport to the appropriate v7.10.x or v7.9.x.
Checklist
self-explanatory (or properly documented)
Testing instructions