Support custom identifiers for items added to Interactions#7644
Merged
grantfitzsimmons merged 18 commits intomainfrom Jan 15, 2026
Merged
Support custom identifiers for items added to Interactions#7644grantfitzsimmons merged 18 commits intomainfrom
grantfitzsimmons merged 18 commits intomainfrom
Conversation
also fixes the local for no preps
Triggered by 4d7c8ec on branch refs/heads/issue-1157
segment the loan return dialog more robustly
CarolineDenis
approved these changes
Jan 14, 2026
emenslin
approved these changes
Jan 14, 2026
Collaborator
emenslin
left a comment
There was a problem hiding this comment.
- Build a query and return a list of existing records with identifiers in a given field
- Create new interactions
- Create a Loan
- Create a Disposal
- Create an Exchange Out
- Create a Gift
- Add items to existing interactions
- Add items to a Loan
- Add items to a Disposal
- Add items to an Exchange Out
- Add items to a Gift
- Verify the system works as expected
- Customize table and field captions for Collection Object, Preparation, and associated fields and verify they are reflected
- Create a new Loan Return from both a record set and verify loan number searching works as expected
Looks good, I didn't run into any issues! The only thought I have is that #7642 should be implemented in order for this to truly be effective. Right now if you are searching for multiple different preparation/collection objects there is no way to tell which one is which in the selection dialog which could be confusing.
Iwantexpresso
approved these changes
Jan 14, 2026
Contributor
Iwantexpresso
left a comment
There was a problem hiding this comment.
- Build a query and return a list of existing records with identifiers in a given field
- Create new interactions
- Create a Loan
- Create a Disposal
- Create an Exchange Out
- Create a Gift
- Add items to existing interactions
- Add items to a Loan
- Add items to a Disposal
- Add items to an Exchange Out
- Add items to a Gift
- Verify the system works as expected
- Customize table and field captions for Collection Object, Preparation, and associated fields and verify they are reflected
- Create a new Loan Return from both a record set and verify loan number searching works as expected
I have not ran into any issues while testing, nice work!
Triggered by 1610ccd on branch refs/heads/issue-1157
kwhuber
approved these changes
Jan 15, 2026
Contributor
kwhuber
left a comment
There was a problem hiding this comment.
- Build a query and return a list of existing records with identifiers in a given field
- Create new interactions
- Create a Loan
- Create a Disposal
- Create an Exchange Out
- Create a Gift
- Add items to existing interactions
- Add items to a Loan
- Add items to a Disposal
- Add items to an Exchange Out
- Add items to a Gift
- Verify the system works as expected
- Customize table and field captions for Collection Object, Preparation, and associated fields and verify they are reflected
- Create a new Loan Return from both a record set and verify loan number searching works as expected
Works as expected!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1157
This PR adds support for creating new interactions using other fields in Collection Object and newly fields in Preparation. This is controlled in User Preferences, and defaults can be set at any level (User, Collection, Discipline, Institution) just as with any other preference.
Preferences
Two new preference items have been added under 'Creating an interaction' in User Preferences:
Users can choose from any of the following fields (and they will be shown the schema caption rather than the data model name):
Preparation-based Interactions
You can now add new items to a Preparation-based interaction based on a field of your choosing from the Preparation table (e.g.
barcodeby default, but others are supported as well).Localization Improvements
The dialog is now responsive to the schema as it has been customized for both table names and field names:
It will display the caption for the table and identifier selected in User Preferences.
If the name of the table has been renamed, it will also now be respected (see RBGE uses "Destructive Sampling" instead of "Gift", this will now display appropriately):
Checklist
self-explanatory (or properly documented)
Testing instructions
Repeat the following steps using various fields from both the Collection Object (CO) and Preparation (configured in User Preferences). The behavior should align with the current functionality observed when searching for catalog numbers or using record sets. However, if you match a specific preparation, it should only return that preparation (by ID) instead of returning all preparations associated with the parent CO.
Test various scenarios (e.g. use identifiers to find records that have no available preps for loan, and verify that is communicated).