Fix Chronostratigraphy Tree name in new disciplines#7824
Merged
CarolineDenis merged 8 commits intomainfrom Mar 23, 2026
Merged
Conversation
emenslin
requested changes
Mar 18, 2026
Collaborator
emenslin
left a comment
There was a problem hiding this comment.
- The new Chronostratigraphy tree should be called "Chronostratigraphy", with no _1 at the end.
- Ensure the tree still works correctly. You should still be able to add nodes to it, edit ranks, etc.
When I created the second discipline 2 chronostrat trees were created, the first one was called "Chronostratigraphy" and the second was "Chronostratigraphy_1".
Contributor
Author
|
@emenslin ah I think I found the issue, it should be fixed now 👍 EDIT: Actually hold off on testing, changing the base messed some stuff up |
Contributor
Author
|
@specify/ux-testing Ok fixed the merge conflict, this is ready for testing again 👍 |
emenslin
approved these changes
Mar 23, 2026
Collaborator
emenslin
left a comment
There was a problem hiding this comment.
- The Chronostratigraphy tree should be called "Chronostratigraphy", with no _1 at the end.
- The new Chronostratigraphy tree should be called "Chronostratigraphy", with no _1 at the end.
- Ensure the tree still works correctly. You should still be able to add nodes to it, edit ranks, etc.
Looks good, my previous issue was fixed!
CarolineDenis
approved these changes
Mar 23, 2026
bhumikaguptaa
approved these changes
Mar 23, 2026
Collaborator
bhumikaguptaa
left a comment
There was a problem hiding this comment.
- The Chronostratigraphy tree should be called "Chronostratigraphy", with no _1 at the end.
- The new Chronostratigraphy tree should be called "Chronostratigraphy", with no _1 at the end.
- Ensure the tree still works correctly. You should still be able to add nodes to it, edit ranks, etc.
--
It works as expected!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7823
When creating a new chronostratigraphy tree with the system configuration tool it would be named "Chronostratigraphy_1".
All new disciplines with chrono trees will now always have them named "Chronostratigraphy", since they are the first and only chrono tree in that discipline.
Checklist
self-explanatory (or properly documented)
Testing instructions