Feat: Prevent user with non UTF-8 encoding to create geo tree#7850
Merged
CarolineDenis merged 4 commits intov7.12.0-prereleasefrom Mar 26, 2026
Merged
Feat: Prevent user with non UTF-8 encoding to create geo tree#7850CarolineDenis merged 4 commits intov7.12.0-prereleasefrom
CarolineDenis merged 4 commits intov7.12.0-prereleasefrom
Conversation
Triggered by 573f744 on branch refs/heads/issue-7842-3
grantfitzsimmons
approved these changes
Mar 25, 2026
kwhuber
approved these changes
Mar 25, 2026
emenslin
requested changes
Mar 26, 2026
Collaborator
emenslin
left a comment
There was a problem hiding this comment.
- Verify that the Geo tree cannot be clicked and that the warning "'This tree data cannot be imported in your database because it contains UTF-8 characters and this database uses {encoding:string}'" is displayed as well as a link to our documentation on how to fix it. (Doc to be created)
The geo tree warning works when adding a tree to an existing collection and when creating a new discipline in system config, but is not caught properly on initial setup. After selecting the geology discipline, if you try to pre-load the geology tree you get an insufficient privileges error instead of the encoding warning.
03-26_08.22.mp4
emenslin
approved these changes
Mar 26, 2026
Collaborator
emenslin
left a comment
There was a problem hiding this comment.
- Verify that the Geo tree cannot be clicked and that the warning "'This tree data cannot be imported in your database because it contains UTF-8 characters and this database uses {encoding:string}'" is displayed as well as a link to our documentation on how to fix it. (Doc to be created)
Looks good, my previous issue was fixed
Iwantexpresso
approved these changes
Mar 26, 2026
Contributor
Iwantexpresso
left a comment
There was a problem hiding this comment.
- Verify that the Geo tree cannot be clicked and that the warning "'This tree data cannot be imported in your database because it contains UTF-8 characters and this database uses {encoding:string}'" is displayed as well as a link to our documentation on how to fix it. (Doc to be created)
I went to double check the issue borough up by elizabeth
looks great!
This was referenced Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fuxes #7842
Checklist
self-explanatory (or properly documented)
Testing instructions