Skip to content

Feat: Prevent user with non UTF-8 encoding to create geo tree#7850

Merged
CarolineDenis merged 4 commits intov7.12.0-prereleasefrom
issue-7842-3
Mar 26, 2026
Merged

Feat: Prevent user with non UTF-8 encoding to create geo tree#7850
CarolineDenis merged 4 commits intov7.12.0-prereleasefrom
issue-7842-3

Conversation

@CarolineDenis
Copy link
Copy Markdown
Contributor

Fuxes #7842

Checklist

  • Self-review the PR after opening it to make sure the changes look good and
    self-explanatory (or properly documented)
  • Add relevant issue to release milestone
  • Add pr to documentation list

Testing instructions

  • Open the tree viewer with a db that do not use UTF-8 encoding
  • Click on create new tree (+)
  • Verify that the Geo tree cannot be clicked and that the warning "'This tree data cannot be imported in your database because it contains UTF-8 characters and this database uses {encoding:string}'" is displayed as well as a link to our documentation on how to fix it. (Doc to be created)

Triggered by 573f744 on branch refs/heads/issue-7842-3
@CarolineDenis CarolineDenis requested review from a team and grantfitzsimmons March 25, 2026 19:13
Copy link
Copy Markdown
Collaborator

@emenslin emenslin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Verify that the Geo tree cannot be clicked and that the warning "'This tree data cannot be imported in your database because it contains UTF-8 characters and this database uses {encoding:string}'" is displayed as well as a link to our documentation on how to fix it. (Doc to be created)

The geo tree warning works when adding a tree to an existing collection and when creating a new discipline in system config, but is not caught properly on initial setup. After selecting the geology discipline, if you try to pre-load the geology tree you get an insufficient privileges error instead of the encoding warning.

03-26_08.22.mp4

@github-project-automation github-project-automation bot moved this from 📋Back Log to Dev Attention Needed in General Tester Board Mar 26, 2026
Base automatically changed from v7_12_0 to v7.12.0-prerelease March 26, 2026 15:27
Copy link
Copy Markdown
Collaborator

@emenslin emenslin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Verify that the Geo tree cannot be clicked and that the warning "'This tree data cannot be imported in your database because it contains UTF-8 characters and this database uses {encoding:string}'" is displayed as well as a link to our documentation on how to fix it. (Doc to be created)

Looks good, my previous issue was fixed

Copy link
Copy Markdown
Contributor

@Iwantexpresso Iwantexpresso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Verify that the Geo tree cannot be clicked and that the warning "'This tree data cannot be imported in your database because it contains UTF-8 characters and this database uses {encoding:string}'" is displayed as well as a link to our documentation on how to fix it. (Doc to be created)
Image

I went to double check the issue borough up by elizabeth

Image

looks great!

@CarolineDenis CarolineDenis merged commit 9c0421d into v7.12.0-prerelease Mar 26, 2026
14 checks passed
@CarolineDenis CarolineDenis deleted the issue-7842-3 branch March 26, 2026 18:00
@github-project-automation github-project-automation bot moved this from Dev Attention Needed to ✅Done in General Tester Board Mar 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅Done

Development

Successfully merging this pull request may close these issues.

Prevent users from creating trees with incorrect encoding

5 participants