Skip to content

fix: remove limit on record sets in search dialog#7916

Open
grantfitzsimmons wants to merge 1 commit intomainfrom
issue-6971
Open

fix: remove limit on record sets in search dialog#7916
grantfitzsimmons wants to merge 1 commit intomainfrom
issue-6971

Conversation

@grantfitzsimmons
Copy link
Copy Markdown
Member

@grantfitzsimmons grantfitzsimmons commented Apr 9, 2026

Fixes #6971

Contributed by @foozleface

The Record Sets button in the Search Dialog used usePaginator with a default limit of 10 (configurable in the record sets dialog) but never rendered the paginator UI, so users could only see the first 10 record sets. Replace with limit: 0 to fetch all record sets for the current user.

Left: issue-6971, Right: v7.12.0-prerelease
image

Checklist

  • Self-review the PR after opening it to make sure the changes look good and
    self-explanatory (or properly documented)
  • Add relevant issue to release milestone
  • Add automated tests

Testing instructions

Make sure you have a large number of record sets for the base table so you can exceed the limit set in the record sets dialog easily. I tested this in situations with hundreds of record sets, and it should become scrollable with that many.

  • Set the limit on the number of record sets per page to 10 in the Record Sets dialog

  • Go to a place where you can search or select a record set (e.g. by clicking the plus in the collection relationship plugin), and select record set, and verify that all record sets of the appropriate base table appear

    Screen.Recording.2026-04-09.at.10.24.03.AM.mov

The Record Sets button in the Search Dialog used usePaginator with a
default limit of 10 but never rendered the paginator UI, so users could
only see the first 10 record sets. Replace with limit: 0 to fetch all
record sets for the current user.
@grantfitzsimmons grantfitzsimmons requested review from a team April 9, 2026 15:26
@github-project-automation github-project-automation Bot moved this to 📋Back Log in General Tester Board Apr 9, 2026
@CarolineDenis CarolineDenis added this to the 7.12.2 milestone Apr 20, 2026
Copy link
Copy Markdown
Collaborator

@bhumikaguptaa bhumikaguptaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Set the limit on the number of record sets per page to 10 in the Record Sets dialog
  • Go to a place where you can search or select a record set (e.g. by clicking the plus in the collection relationship plugin), and select record set, and verify that all record sets of the appropriate base table appear

--
Works as expected. I was able to see all the possible record sets.

Image

@bhumikaguptaa bhumikaguptaa requested a review from a team April 20, 2026 15:44
Copy link
Copy Markdown
Collaborator

@emenslin emenslin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Set the limit on the number of record sets per page to 10 in the Record Sets dialog
  • Go to a place where you can search or select a record set (e.g. by clicking the plus in the collection relationship plugin), and select record set, and verify that all record sets of the appropriate base table appear

Looks good!

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 📋Back Log

Development

Successfully merging this pull request may close these issues.

Search Dialog "Record Sets" Button Displays Incomplete/Limited List

6 participants